-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate useContext (part 2) #37
Translate useContext (part 2) #37
Conversation
Thanks a lot Asif vai for making quick translations. I would like to request you to not open more than one PR at a time as mentioned in our guidelines. It will help us keep our PR list simple. So, let's open another PR after the previous one is merged and closed. Larger PRs are difficult to review. SImilarly, too many PRs mean too many back and forths. We are trying to find a sweet spot. I think, we can easily accommodate 60/80 line changes in one PR, meaning 40 additions and 40 deletions. Thanks again for your contribution. |
Size changes📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
@asif-jalil bhai assuming you got what @nafistiham bhai explained. |
Yeah got it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
বেশ গোছানো ভাষান্তর হয়েছে। অনেক ধন্যবাদ। কিছু টাইপো রিকুয়েস্ট করেছি। আর আমরা নন টেকনিকাল শব্ধগুলো একটু বামে ডানে গিয়ে বাংলা করে ফেলতে পারি। সেগুলো ইংরেজি হরফে বা ইংরেজি উচ্চারণে রাখা জরুরি না। ৬৫ নাম্বার লাইনে অমিল ছিল। আবার নিচে একটা লাইন অতিরিক্ত ইংরেজি আছে। দুইটা ঠিক করলে সম্পূর্ণ মিলে যাবে।
যেহেতু দুটি PR এ দিয়েছেন, আমাদের ইস্যুর পরিচ্ছন্নতার জন্য অনুরোধ থাকবে PR দুইটার নাম সহজ করে useContext part 1, useContext part 2 বা সেরকম কিছু করে দেবেন। আবারও ধন্যবাদ।
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work Asif bhai! LGTM!
Translate useContext hook's usages.