Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate: State a component memory #38

Merged
merged 3 commits into from
Nov 9, 2023

Conversation

moinulse
Copy link
Contributor

Description

Why this PR?

This PR contains the partial translation of the State - A components Memory page in React Documentation:

@github-actions
Copy link

github-actions bot commented May 23, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 103.96 KB (🟡 +212 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 77.92 KB (🟢 -85 B) 181.88 KB
/500 77.92 KB (🟢 -85 B) 181.88 KB
/[[...markdownPath]] 79.46 KB (🟢 -134 B) 183.42 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@moshfiqrony
Copy link
Collaborator

Thank you so much @moinul192000. If any PR is partially completed no need to write it in the PR title. Please create the PR as draft.

@moinulse moinulse changed the title Translate: State a component memory (Partially Translated) Translate: State a component memory May 24, 2023
@moinulse moinulse marked this pull request as draft May 24, 2023 05:46
@moinulse
Copy link
Contributor Author

Thank you so much @moinul192000. If any PR is partially completed no need to write it in the PR title. Please create the PR as draft.

Thanks for the guideline, I have updated accordingly.

Copy link
Collaborator

@moshfiqrony moshfiqrony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

লিখার পরে আবার মনোযোগ দিয়ে একবার পড়ে নিবেন। বুঝার চেষ্টা korben যে ajob লাগে নাকি

src/content/learn/state-a-components-memory.md Outdated Show resolved Hide resolved
src/content/learn/state-a-components-memory.md Outdated Show resolved Hide resolved
src/content/learn/state-a-components-memory.md Outdated Show resolved Hide resolved
src/content/learn/state-a-components-memory.md Outdated Show resolved Hide resolved
@moshfiqrony
Copy link
Collaborator

Any update on this?

@moinulse
Copy link
Contributor Author

Any update on this?

Partially Done with the issues resolved. Someone else can take it from here.

@moinulse moinulse marked this pull request as ready for review November 2, 2023 17:32
@nafistiham
Copy link
Collaborator

I'll take over this task after I am finished with my current one. So, I am making it draft again for the time being. I'll merge it and finish it with a new PR.

@nafistiham nafistiham marked this pull request as draft November 7, 2023 08:42
@nafistiham nafistiham marked this pull request as ready for review November 9, 2023 11:06
Copy link
Collaborator

@nafistiham nafistiham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partially done. I'll finish the rest.

@nafistiham nafistiham dismissed moshfiqrony’s stale review November 9, 2023 11:11

I'll adapt the review

@nafistiham nafistiham added this pull request to the merge queue Nov 9, 2023
Merged via the queue into reactjs:main with commit 0a74943 Nov 9, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants