Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translated: queueing-a-series-of-state-updates #41

Merged
merged 11 commits into from
May 28, 2023

Conversation

deveasin
Copy link
Contributor

I have translated queueing-a-series-of-state-updates page. If we need any changes, please help me to find it. I will try to solve it.

Thanks

Copy link
Collaborator

@nafistiham nafistiham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

স্যান্ডবক্সের কোডের মধ্যে বাংলা আপাতত ঢুকাচ্ছি না আমরা। শুধুমাত্র পেইজের কিছু বাটন আর স্যান্ড বক্সের কমেন্টে বাংলা আনছি। কারণ কিছু কিছু ক্ষেত্রে স্ক্রিনশটের বিষয় আছে। আর মূল ডকের সাথে মিলার বিষয় আছে। সুতরাং সেটা অনুসারে ভিতরের লেখাও আশা করি ঠিক করে ফেলবেন। দুই-একটা টাইপো ছিল। আরো থাকতে পারে যদি মিস হয়ে থাকে। বাংলা ভাষার সাধারণ ব্যবহারের মত আমরা কোলনের জায়গায় বিসর্গ ব্যবহার করছি।

অনেক ধন্যবাদ অনেক বড় একটি পেইজের কাজ এগিয়ে ফেলেছেন। @nomandhoni-cs ভাই, উনার কমিট ফিক্সের পরে আপনি একবার দেখে দিয়েন আমি যদি কিছু মিস করে থাকি।

src/components/MDX/Recap.tsx Outdated Show resolved Hide resolved
src/content/learn/queueing-a-series-of-state-updates.md Outdated Show resolved Hide resolved
src/content/learn/queueing-a-series-of-state-updates.md Outdated Show resolved Hide resolved
src/content/learn/queueing-a-series-of-state-updates.md Outdated Show resolved Hide resolved
src/content/learn/queueing-a-series-of-state-updates.md Outdated Show resolved Hide resolved
src/content/learn/queueing-a-series-of-state-updates.md Outdated Show resolved Hide resolved
src/content/learn/queueing-a-series-of-state-updates.md Outdated Show resolved Hide resolved
src/content/learn/queueing-a-series-of-state-updates.md Outdated Show resolved Hide resolved
src/content/learn/queueing-a-series-of-state-updates.md Outdated Show resolved Hide resolved
src/content/learn/queueing-a-series-of-state-updates.md Outdated Show resolved Hide resolved
deveasin and others added 8 commits May 26, 2023 02:34
Co-authored-by: Nafis Tiham <nafistiham@gmail.com>
Co-authored-by: Nafis Tiham <nafistiham@gmail.com>
Co-authored-by: Nafis Tiham <nafistiham@gmail.com>
Co-authored-by: Nafis Tiham <nafistiham@gmail.com>
Co-authored-by: Nafis Tiham <nafistiham@gmail.com>
Co-authored-by: Nafis Tiham <nafistiham@gmail.com>
Co-authored-by: Nafis Tiham <nafistiham@gmail.com>
Co-authored-by: Nafis Tiham <nafistiham@gmail.com>
@nafistiham
Copy link
Collaborator

@deveasin , may I know why you are putting every line of change with one commit?

@deveasin
Copy link
Contributor Author

@nafistiham Sorry, I did it from the github when I was reviewing the comments(I thought it was easier to do it). Next time I will not do it.


Thanks a lot for reviewing it. I have updated the requested changes. You may review it again please when you are free.

Sorry again for the inconvenience.

Thanks

@deveasin deveasin requested a review from nafistiham May 25, 2023 20:22
@nafistiham
Copy link
Collaborator

Oh no it's not an issue. I thought, could you have done it intentionally Haha. Hence asked.

@nomandhoni-cs
Copy link
Collaborator

স্যান্ডবক্সের কোডের মধ্যে বাংলা আপাতত ঢুকাচ্ছি না আমরা। শুধুমাত্র পেইজের কিছু বাটন আর স্যান্ড বক্সের কমেন্টে বাংলা আনছি। কারণ কিছু কিছু ক্ষেত্রে স্ক্রিনশটের বিষয় আছে। আর মূল ডকের সাথে মিলার বিষয় আছে। সুতরাং সেটা অনুসারে ভিতরের লেখাও আশা করি ঠিক করে ফেলবেন। দুই-একটা টাইপো ছিল। আরো থাকতে পারে যদি মিস হয়ে থাকে। বাংলা ভাষার সাধারণ ব্যবহারের মত আমরা কোলনের জায়গায় বিসর্গ ব্যবহার করছি।

অনেক ধন্যবাদ অনেক বড় একটি পেইজের কাজ এগিয়ে ফেলেছেন। @nomandhoni-cs ভাই, উনার কমিট ফিক্সের পরে আপনি একবার দেখে দিয়েন আমি যদি কিছু মিস করে থাকি।

I apologize for the delay, but I've been working on a Hackathon project. I'll have this done by this evening.

Co-authored-by: Noman Dhoni <92979541+nomandhoni-cs@users.noreply.github.com>
@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 75.81 KB (🟡 +12 B) 178.97 KB
/500 75.8 KB (🟡 +12 B) 178.96 KB
/[[...markdownPath]] 77.22 KB (🟡 +12 B) 180.38 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@moshfiqrony
Copy link
Collaborator

@deveasin is it completed from your side? I mean all the reviews?

@deveasin
Copy link
Contributor Author

@moshfiqrony All request changes have been done from my side.

@moshfiqrony
Copy link
Collaborator

Great I will try to give my review by tonight.

Copy link
Collaborator

@moshfiqrony moshfiqrony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@moshfiqrony moshfiqrony merged commit f54073d into reactjs:main May 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants