Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create-root #50

Merged
merged 6 commits into from
Jun 8, 2023
Merged

create-root #50

merged 6 commits into from
Jun 8, 2023

Conversation

nafistiham
Copy link
Collaborator

No description provided.

@nafistiham nafistiham changed the title create-root-wip-20% create-root Jun 1, 2023
@github-actions
Copy link

github-actions bot commented Jun 1, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link
Collaborator

@moshfiqrony moshfiqrony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The translation is legit. I had some confusion so asked about it.


* The first time you call `root.render`, React will clear all the existing HTML content inside the React root before rendering the React component into it.
* আপনি যখন প্রথম বারের মত `root.render` কল করবেন, React এর রুটের ভিতরে কম্পোনেন্ট রেন্ডার করবার আগে থাকা সব HTML কনটেন্ট মুছে ফেলবে।

* If your root's DOM node contains HTML generated by React on the server or during the build, use [`hydrateRoot()`](/reference/react-dom/client/hydrateRoot) instead, which attaches the event handlers to the existing HTML.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bhai ei line ta ki intentionally translate korenni?

src/content/reference/react-dom/client/createRoot.md Outdated Show resolved Hide resolved
src/content/reference/react-dom/client/createRoot.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@moshfiqrony moshfiqrony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@moshfiqrony moshfiqrony added this pull request to the merge queue Jun 8, 2023
Merged via the queue into reactjs:main with commit dedf127 Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants