Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Learn React intro translation #7

Merged
merged 2 commits into from
May 1, 2023

Conversation

anwarhossain1
Copy link
Contributor

No description provided.

@moshfiqrony
Copy link
Collaborator

Thanks for your effort in the translation. I suggest reading #1 and the readme.md to know how to get started with the contribution.

@anwarhossain1
Copy link
Contributor Author

@moshfiqrony is there any mistake I did? This is going to be my first contribution.

@@ -4,7 +4,7 @@ title: Quick Start

<Intro>

Welcome to the React documentation! This page will give you an introduction to the 80% of React concepts that you will use on a daily basis.
রিএক্ট ডকুমেন্টেশনে স্বাগতম! এই পৃষ্ঠাটি আপনাকে ৮০% ভূমিকা দেবে রিএক্ট এর, যা আপনি প্রতিদিন ব্যবহার করবেন।
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets discuss if we should keep the word "React" as it is, or should we call it রিএক্ট or not

@moshfiqrony, @ahmmedabir9, @nazir021, @nomandhoni-cs, @shakib609, @nutboltu, @nafistiham

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep it "React"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I concur with Rony bhai. This is like a brand name which is better left as it is.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also prefer to keep is react, and not only this one. all the key words we can keep same. for example, Components, Props, State, etc.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anwarhossain1 wanna update it to say React, please and thank you?

On a separate note,
We should make a new updated version of this and link it in our guidelines for contributing?
This way everyone will already know what words to avoid writing it phonetically in bengali?
https://github.com/stale-reactjs-org-translations/bn.reactjs.org/wiki/Glossary

@ahmmedabir9 looking at the glossary above, people chose to write কম্পোনেন্ট for Component.
State and props were left as it is. Same as React!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahnafyy updated it with React.

@moshfiqrony
Copy link
Collaborator

Let's update the PR label to "Quick start page translation" or "Learn React intro translation"

@moshfiqrony
Copy link
Collaborator

@moshfiqrony is there any mistake I did? This is going to be my first contribution.

@anwarhossain1 When you are picking a page at first comment about it in the issue link I gave. Think about a situation where some one else is already picked the page and working on it but didn't gave PR. It will be waste of time right? So the procedure is comment in the issue what page you want to translate one maintainer will confirm it then you should start working on it.

You can join our discord from this link - https://discord.gg/ER3DzHEh

@moshfiqrony
Copy link
Collaborator

Let's update the PR label to "Quick start page translation" or "Learn React intro translation"

Can you change the PR title @anwarhossain1 ?

@anwarhossain1 anwarhossain1 changed the title intro translated Learn React intro translation May 1, 2023
@anwarhossain1
Copy link
Contributor Author

@moshfiqrony I changed the title.

@moshfiqrony
Copy link
Collaborator

Great! Thanks @anwarhossain1

Copy link
Collaborator

@ahnafyy ahnafyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏆 💯 🥇

@github-actions
Copy link

github-actions bot commented May 1, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@ahnafyy ahnafyy added this pull request to the merge queue May 1, 2023
Merged via the queue into reactjs:main with commit 4f558c9 May 1, 2023
@moshfiqrony
Copy link
Collaborator

moshfiqrony commented May 1, 2023

@anwarhossain1 assuming you are still working on rest of the pages.

Copy link

@clevermiraz clevermiraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

React ডকুমেন্টেশনে আপনাকে স্বাগতম ! এই পৃষ্ঠাটি আপনাকে ৮০% ধারনা দেবে React এর, যা আপনি প্রতিনিয়ত ব্যবহার করবেন।

  • What is the opinion To Improve This?

@moshfiqrony
Copy link
Collaborator

@clevermiraz there is a pr open for this page. Let's discuss it there #10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants