Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thinking-in-react-till-3rd-step #8

Merged
merged 9 commits into from
May 4, 2023

Conversation

nafistiham
Copy link
Collaborator

This is WIP. Creating a PR for simultaneous review. Please don't merge it before the whole page is done.

@github-actions
Copy link

github-actions bot commented May 1, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@moshfiqrony
Copy link
Collaborator

@nafistiham bhai make it draft from the next time. Then no one will be able to merge it but will be able to give review.

@nafistiham nafistiham marked this pull request as draft May 1, 2023 13:00
@nafistiham
Copy link
Collaborator Author

@nafistiham bhai make it draft from the next time. Then no one will be able to merge it but will be able to give review.

Thanks. Turned it into a draft.

@nafistiham nafistiham marked this pull request as ready for review May 2, 2023 21:20
@nafistiham nafistiham changed the title WIP-thinking-in-react Thinking-in-react-till-3rd-step May 2, 2023
src/content/learn/thinking-in-react.md Outdated Show resolved Hide resolved
src/content/learn/thinking-in-react.md Outdated Show resolved Hide resolved
src/content/learn/thinking-in-react.md Outdated Show resolved Hide resolved
src/content/learn/thinking-in-react.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@nomandhoni-cs nomandhoni-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nafistiham Bhai, Thanks again for an amazing translation. 👏
I added an word, I guess you missed that. I am approving this PR.

src/content/learn/thinking-in-react.md Outdated Show resolved Hide resolved
@nafistiham nafistiham added this pull request to the merge queue May 4, 2023
Merged via the queue into reactjs:main with commit 29b59e5 May 4, 2023
@nafistiham nafistiham deleted the thinking-in-react branch May 4, 2023 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants