Add June 2 notes #18
Add June 2 notes #18
Conversation
|
Proposal 3 is super cool 👍 It gives developers 100% clarity and control over this functionality. |
|
I am strictly disagree with second proposal. In my case I'm already sure that if SFCs get new props, this props are really new (not equal to previous) so I need a way to always re-render as fast as possible on new props without any checks |
| * Intuitively, people expect SFCs to behave like functions. The bailout would be surprising, and there isn’t a particularly good way of discovering why the function isn’t behaving like a normal JavaScript function. | ||
| * Performance. It’s not clear that adding `PureRenderMixin` to every SFC would actually improve overall performance (because it means extra reads/compares, retaining objects longer and into subsequent GC generations, etc). | ||
|
|
||
| #### Proposal 3: `createPureElement` |
There was a problem hiding this comment.
This seems really clean. I like the <*Component /> syntax, though I think pure={true} better fits what my expectation would be if someone asked me 'how do you tell if a component implements (formerly) PureRenderMixin?'
The downside would be that the calling component must have additional information on the expectations of the component. I suspect folks would just end up defining pure: true in getDefaultProps.
There was a problem hiding this comment.
Has there been a discussion of pros and cons of the third approach? I missed the meeting so I can’t tell 😄 .
Feel free to discuss in this PR!