Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate: React without ES6 #118

Merged
merged 17 commits into from
Feb 7, 2019

Conversation

adielhercules
Copy link
Contributor

@adielhercules adielhercules commented Feb 7, 2019

Translate: React without ES6

Reference to #109

@adielhercules adielhercules changed the title [WIP] Translate: React without ES6 Translate: React without ES6 Feb 7, 2019
Copy link
Member

@carburo carburo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @adielhercules. Welcome!
I made some corrections and suggetions that I think should be addressed before merging.
Thank you for your contribution!

content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
carburo and others added 10 commits February 7, 2019 11:53
change plana -> simple (as suggested)

Co-Authored-By: adielhercules <jadher.11x2@gmail.com>
change es definido -> se define (as suggested)

Co-Authored-By: adielhercules <jadher.11x2@gmail.com>
change pasado a createReactClass -> que se le pasa (as suggested)

Co-Authored-By: adielhercules <jadher.11x2@gmail.com>
change linea -> línea (as suggested)

Co-Authored-By: adielhercules <jadher.11x2@gmail.com>
change event handler -> *event handler* (as suggested)

Co-Authored-By: adielhercules <jadher.11x2@gmail.com>
change funciones de flecha -> funciones flecha (as suggested)

Co-Authored-By: adielhercules <jadher.11x2@gmail.com>
change correaran -> se ejecutan (as suggested)

Co-Authored-By: adielhercules <jadher.11x2@gmail.com>
change tu aun -> aun (as suggested)

Co-Authored-By: adielhercules <jadher.11x2@gmail.com>
change tu debes -> debes (as suggested)

Co-Authored-By: adielhercules <jadher.11x2@gmail.com>
change typos (as suggested)

Co-Authored-By: adielhercules <jadher.11x2@gmail.com>
@adielhercules
Copy link
Contributor Author

@carburo perfect, I already pushed all the suggestions! Thanks

@adielhercules
Copy link
Contributor Author

Oh it seems that I still have a few suggestions pending to be fixed, let me fix that.

carburo and others added 6 commits February 7, 2019 12:04
change on sentence about properties binding (as suggested)

Co-Authored-By: adielhercules <jadher.11x2@gmail.com>
change parts on sentence about performance when using `.bind` explicitly (as suggested)

Co-Authored-By: adielhercules <jadher.11x2@gmail.com>
change on sentence about boilerplate alternative (as suggested)

Co-Authored-By: adielhercules <jadher.11x2@gmail.com>
change to fix typo (as suggested)

Co-Authored-By: adielhercules <jadher.11x2@gmail.com>
change to fix typo (as suggested)

Co-Authored-By: adielhercules <jadher.11x2@gmail.com>
change to fix typos on experimental warning (as suggested)

Co-Authored-By: adielhercules <jadher.11x2@gmail.com>
@carburo
Copy link
Member

carburo commented Feb 7, 2019

Ok, I think we are good to go. Thanks again!

@carburo carburo merged commit cbd4cae into reactjs:master Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants