Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spanish translation of faq-functions #124

Merged
merged 7 commits into from
Feb 14, 2019

Conversation

florenciasilva
Copy link
Contributor

References to #4
@dmoralesm , @carburo and @alejandronanez

Copy link
Member

@carburo carburo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @florenciasilva Thank you for your contribution!
Please, take a look at the suggestions I made and feel free to reply when you don't agree.

content/docs/faq-functions.md Outdated Show resolved Hide resolved
content/docs/faq-functions.md Outdated Show resolved Hide resolved
content/docs/faq-functions.md Outdated Show resolved Hide resolved
content/docs/faq-functions.md Outdated Show resolved Hide resolved
content/docs/faq-functions.md Outdated Show resolved Hide resolved
content/docs/faq-functions.md Outdated Show resolved Hide resolved
content/docs/faq-functions.md Outdated Show resolved Hide resolved
content/docs/faq-functions.md Outdated Show resolved Hide resolved
content/docs/faq-functions.md Outdated Show resolved Hide resolved
content/docs/faq-functions.md Outdated Show resolved Hide resolved
@carburo carburo changed the title Spanish translation of faq-functions to a 100%, pending feedback Spanish translation of faq-functions Feb 12, 2019
Co-Authored-By: florenciasilva <hensgrej@gmail.com>
@alejandronanez
Copy link
Member

Hey @florenciasilva, welcome to the project!!! Is this ready for another review?

Thanks!

Co-Authored-By: florenciasilva <hensgrej@gmail.com>
@florenciasilva
Copy link
Contributor Author

Hey @florenciasilva, welcome to the project!!! Is this ready for another review?

Thanks!

Hey! I just committed all the changes, so it should be ready for a review!

@carburo
Copy link
Member

carburo commented Feb 14, 2019

Thank you! I'm merging it then.

@carburo carburo merged commit f729af3 into reactjs:master Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants