Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate: Basics > Forms #132

Merged
merged 7 commits into from
Feb 15, 2019
Merged

Translate: Basics > Forms #132

merged 7 commits into from
Feb 15, 2019

Conversation

Darking360
Copy link
Collaborator

@Darking360 Darking360 commented Feb 9, 2019

Translation of Basics: Forms

Related: Original issue: Spanish Translation Progress

To Do:

  • Finish first translation draft

  • Check translation

  • Check grammar and orthography

  • Submit final

@tesseralis
Copy link
Member

@Darking360 are you ready for a review? They might be able to help you with grammar, that's what reviews are for :)

@Darking360
Copy link
Collaborator Author

Greetings @tesseralis I'm correcting some orthography issues and accents left in the way, and reading it again before submitting it for review. As soon as I have something solid for you guys to read I'll update the PR 💪

I'll work on this the next hour or so 🚀

@Darking360 Darking360 changed the title [WIP] Translate: Basics > Forms Translate: Basics > Forms Feb 15, 2019
@Darking360
Copy link
Collaborator Author

Greetings! 🌞

I just finished this translation, I was checking some spelling and accents, if some of you can take a look 🙏 Also something that bothers my mind a little, is regarding the word input I didn't see it in the translation style guide, but even so I translated it in the parts where it make sense to translate it, and left it as input in one paragraph I think, so please be careful when reading it 💪

Let me know if anything changes. Thanks a lot! 🚀

CC: @alejandronanez @carburo @dmoralesm

Copy link
Member

@carburo carburo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, great job! I just fixed a few typos and made one or two style recommendations. Take a look!

content/docs/forms.md Outdated Show resolved Hide resolved
content/docs/forms.md Outdated Show resolved Hide resolved
content/docs/forms.md Outdated Show resolved Hide resolved
content/docs/forms.md Outdated Show resolved Hide resolved
content/docs/forms.md Outdated Show resolved Hide resolved
content/docs/forms.md Outdated Show resolved Hide resolved
content/docs/forms.md Outdated Show resolved Hide resolved
content/docs/forms.md Outdated Show resolved Hide resolved
content/docs/forms.md Outdated Show resolved Hide resolved
content/docs/forms.md Outdated Show resolved Hide resolved
@Darking360
Copy link
Collaborator Author

Hey @carburo thanks for the amazing review, as usual! 👊 🎊

I just added your feedback, and thanks for the suggestions 🚀 If you could take a look again 🙏

Thanks a lot once more! 💯

CC: @dmoralesm @alejandronanez

@carburo
Copy link
Member

carburo commented Feb 15, 2019

Thank you! I'm merging it. And welcome as to the crew of maintainers!

@carburo carburo merged commit 157ef5a into reactjs:master Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants