Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Done] Translate: Design Principles #146

Merged
merged 8 commits into from
Feb 15, 2019

Conversation

elyalvarado
Copy link
Contributor

No description provided.

@elyalvarado
Copy link
Contributor Author

#4

@elyalvarado elyalvarado changed the title WIP Translate: Design Principles [Done] Translate: Design Principles Feb 14, 2019
@carburo carburo self-requested a review February 14, 2019 22:27
Copy link
Member

@carburo carburo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thank you! The review is ready. Most of it is reduced to a few typos. I also added heading ids, as described in the translation guide. Check it out.

content/docs/design-principles.md Outdated Show resolved Hide resolved
content/docs/design-principles.md Outdated Show resolved Hide resolved
content/docs/design-principles.md Outdated Show resolved Hide resolved
content/docs/design-principles.md Outdated Show resolved Hide resolved
content/docs/design-principles.md Outdated Show resolved Hide resolved
content/docs/design-principles.md Outdated Show resolved Hide resolved
content/docs/design-principles.md Outdated Show resolved Hide resolved
content/docs/design-principles.md Outdated Show resolved Hide resolved
content/docs/design-principles.md Outdated Show resolved Hide resolved
content/docs/design-principles.md Outdated Show resolved Hide resolved
carburo and others added 2 commits February 14, 2019 20:37
Co-Authored-By: elyalvarado <elyalvarado@gmail.com>
@elyalvarado
Copy link
Contributor Author

@carburo, thanks for your review. I applied all of the suggested changes, it was a really long and complex article and even though I read it 3 times it was hard for me to spot any errors.

@carburo carburo merged commit cfedfbe into reactjs:master Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants