integrating-with-other-libraries translated to spanish #175

jvelezpo · 2019-02-18T23:41:05Z

Relates to #4

content/docs/integrating-with-other-libraries.md

EzequielMonforte · 2019-02-19T04:11:42Z

content/docs/integrating-with-other-libraries.md


-React is unaware of changes made to the DOM outside of React. It determines updates based on its own internal representation, and if the same DOM nodes are manipulated by another library, React gets confused and has no way to recover.
+React no es consciente de los cambios realizados en el DOM fuera de React. React determina las actualizaciones basándose en su propia representación interna, y si los mismos nodos DOM son manipulados por otra biblioteca, React se confunde y no tiene forma de recuperarse.


What do you think about inconsciente instead of no es consciente ?

And I suggest

y si los mismos nodos del DOM

Also consider leaving the part {#integrating-with-dom-manipulation-plugins} its used for navigation
https://github.com/reactjs/es.reactjs.org/blob/master/TRANSLATION.md

content/docs/integrating-with-other-libraries.md

EzequielMonforte · 2019-02-19T04:15:44Z

content/docs/integrating-with-other-libraries.md


-We will attach a [ref](/docs/refs-and-the-dom.html) to the root DOM element. Inside `componentDidMount`, we will get a reference to it so we can pass it to the jQuery plugin.
+Adjuntaremos un [ref](/docs/refs-and-the-dom.html) al elemento DOM raíz. Dentro de `componentDidMount`, obtendremos una referencia a él para que podamos pasarlo al plugin jQuery.


I suggest al elemento raíz del DOM and obtendremos una referencia a este

EzequielMonforte · 2019-02-19T04:30:25Z

content/docs/integrating-with-other-libraries.md

@@ -39,21 +39,22 @@ class SomePlugin extends React.Component {
 }
 ```

-Note that we defined both `componentDidMount` and `componentWillUnmount` [lifecycle methods](/docs/react-component.html#the-component-lifecycle). Many jQuery plugins attach event listeners to the DOM so it's important to detach them in `componentWillUnmount`. If the plugin does not provide a method for cleanup, you will probably have to provide your own, remembering to remove any event listeners the plugin registered to prevent memory leaks.
+Tenga en cuenta que definimos `componentDidMount` y` componentWillUnmount` [métodos del ciclo de vida](/docs/react-component.html#the-component-lifecycle). Muchos plugins de jQuery adjuntan listeners de eventos al DOM, por lo que es importante desmontarlos en `componentWillUnmount`. Si el complemento no proporciona un método para la limpieza, probablemente tendrás que proporcionar el tuyo, recordando eliminar cualquier listener de eventos que el plugin haya registrado para evitar pérdidas de memoria.


We are refering to the user as tú instead of usted .Maybe you can change Tenga by Ten

EzequielMonforte · 2019-02-19T04:33:03Z

content/docs/integrating-with-other-libraries.md


 For a more concrete example of these concepts, let's write a minimal wrapper for the plugin [Chosen](https://harvesthq.github.io/chosen/), which augments `<select>` inputs.
+Para un ejemplo más concreto de estos conceptos, escribamos un wrapper mínimo para el plugin [Elegido](https://harvesthq.github.io/chosen/), que aumenta las entradas `<select>`.


I think there's an extra jump of line here

content/docs/integrating-with-other-libraries.md

EzequielMonforte · 2019-02-19T04:49:24Z

content/docs/integrating-with-other-libraries.md


-Finally, there is one more thing left to do. In React, props can change over time. For example, the `<Chosen>` component can get different children if parent component's state changes. This means that at integration points it is important that we manually update the DOM in response to prop updates, since we no longer let React manage the DOM for us.
+Finalmente, queda una cosa más por hacer. En React, los props pueden cambiar con el tiempo. Por ejemplo, el componente `<Chosen>` puede obtener diferentes hijos si el estado del componente padre cambia. Esto significa que en los puntos de integración es importante que actualicemos manualmente el DOM en respuesta a las actualizaciones de los props, ya que no dejamos que React administre el DOM por nosotros.


IMO las props instead of los props could sound better. What do you think?

EzequielMonforte · 2019-02-19T04:52:13Z

content/docs/integrating-with-other-libraries.md


-## Integrating with Other View Libraries {#integrating-with-other-view-libraries}
+## Integración con otras librerias de vista


I suggest keep the capital letters in the titles as the original doc

This is common in English, but not quite in Spanish. For consistency, we are using sentence-style capitalization. We could have a further discussion about this when we added to the style guide.

content/docs/integrating-with-other-libraries.md

EzequielMonforte · 2019-02-19T04:56:48Z

content/docs/integrating-with-other-libraries.md

@@ -227,7 +228,7 @@ ReactDOM.render(
 );
 ```

-From here you could start moving more logic into the component and begin adopting more common React practices. For example, in components it is best not to rely on IDs because the same component can be rendered multiple times. Instead, we will use the [React event system](/docs/handling-events.html) and register the click handler directly on the React `<button>` element:
+Desde aquí, puedes comenzar a mover más lógica al componente y comenzar a adoptar prácticas de React más comunes. Por ejemplo, en los componentes es mejor no confiar en las ID porque el mismo componente se puede representar varias veces. En su lugar, usaremos el [sistema de eventos de React](/docs/handling-events.html) y registraremos el controlador de clic directamente en el elemento React `<button>`:


IMO los ID sounds better than las ID

content/docs/integrating-with-other-libraries.md

EzequielMonforte · 2019-02-19T05:07:54Z

content/docs/integrating-with-other-libraries.md


-In the example below, we will make a copy of the model's attributes to form the initial state. We subscribe to the `change` event (and unsubscribe on unmounting), and when it happens, we update the state with the model's current attributes. Finally, we make sure that if the `model` prop itself changes, we don't forget to unsubscribe from the old model, and subscribe to the new one.
+En el siguiente ejemplo, haremos una copia de los atributos del modelo para formar el estado inicial. Nos suscribimos al evento `change` (y cancelamos la suscripción al desmontar), y cuando sucede, actualizamos el estado con los atributos actuales del modelo. Finalmente, nos aseguramos de que si el prop `model` cambia, no nos olvidemos de cancelar la suscripción del modelo anterior y suscribirnos al nuevo.


Consider la prop instead of el prop

carburo

Hi! Thanks for your contribution. I made some suggestions that I think should be addressed before merging. Feel free to reply to any of them. Also check the following:

The title is untranslated. Currently in the navbar we have "Integración con otras bibliotecas"
There is an inconsistent use of "wrapper" and "envoltorio". It would be probably better to use just one of them. If, due to context, you feel the other fits better, state in the text that the are interchangeable.
Also thanks to @EzequielMonforte. He also made some suggestions.

Edit

Apparently, we were making both reviews at the same time, so some suggestions may overlap.

content/docs/integrating-with-other-libraries.md

EzequielMonforte · 2019-02-19T05:17:33Z

Hey @jvelezpo ! I leave some suggestions

Consider refer the reader as tú and have a look to the titles
Please, let me know if you need help!

Co-Authored-By: jvelezpo <jvelezpo@users.noreply.github.com>

netlify · 2019-02-20T14:25:03Z

Deploy preview for es-reactjs ready!

Built with commit d62b865

https://deploy-preview-175--es-reactjs.netlify.com

Co-Authored-By: jvelezpo <jvelezpo@users.noreply.github.com>

netlify · 2019-02-20T14:29:32Z

Deploy preview for es-reactjs ready!

Built with commit 4376470

https://deploy-preview-175--es-reactjs.netlify.com

Co-Authored-By: jvelezpo <jvelezpo@users.noreply.github.com>

netlify · 2019-02-20T14:34:52Z

Deploy preview for es-reactjs ready!

Built with commit 2c3bb71

https://deploy-preview-175--es-reactjs.netlify.com

netlify · 2019-02-20T14:39:34Z

Deploy preview for es-reactjs ready!

Built with commit 8ac64b7

https://deploy-preview-175--es-reactjs.netlify.com

jvelezpo · 2019-02-21T13:38:16Z

@carburo hi!
made the fixes, this PR is ready to its final review 👍
Thanks for your comments @carburo and @EzequielMonforte

integrating-with-other-libraries translated to spanish

19e5f14

carburo self-requested a review February 19, 2019 01:54

carburo added needs-review has-reviewer labels Feb 19, 2019

EzequielMonforte reviewed Feb 19, 2019

View reviewed changes

content/docs/integrating-with-other-libraries.md Outdated Show resolved Hide resolved