Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translated render-props #182

Merged
merged 15 commits into from
Feb 27, 2019
Merged

Translated render-props #182

merged 15 commits into from
Feb 27, 2019

Conversation

jonathanpalma
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Feb 25, 2019

Deploy preview for es-reactjs ready!

Built with commit 5ba9be0

https://deploy-preview-182--es-reactjs.netlify.com

Copy link
Collaborator

@Darking360 Darking360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greetings @jonathanpalma ! Thank you for a great job! 🚀

I left you some comments, it's really good in general, just take back to english some code parts that we're not translating, a little typo and some changes to give a clearer reading. Please let me know for any questions or when you have those 💪 Then we'd be good to go 🥇

content/docs/render-props.md Outdated Show resolved Hide resolved
content/docs/render-props.md Outdated Show resolved Hide resolved
content/docs/render-props.md Outdated Show resolved Hide resolved
@@ -42,22 +42,22 @@ class MouseTracker extends React.Component {
render() {
return (
<div style={{ height: '100%' }} onMouseMove={this.handleMouseMove}>
<h1>Move the mouse around!</h1>
<p>The current mouse position is ({this.state.x}, {this.state.y})</p>
<h1>¡Mueve el cursor alrededor!</h1>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<h1>¡Mueve el cursor alrededor!</h1>
<h1>Move the mouse around!</h1>

content/docs/render-props.md Outdated Show resolved Hide resolved
content/docs/render-props.md Outdated Show resolved Hide resolved
content/docs/render-props.md Outdated Show resolved Hide resolved
content/docs/render-props.md Outdated Show resolved Hide resolved
content/docs/render-props.md Outdated Show resolved Hide resolved
content/docs/render-props.md Outdated Show resolved Hide resolved
Darking360 and others added 7 commits February 25, 2019 13:13
Co-Authored-By: jonathanpalma <tanpalma04@gmail.com>
Co-Authored-By: jonathanpalma <tanpalma04@gmail.com>
Co-Authored-By: jonathanpalma <tanpalma04@gmail.com>
Co-Authored-By: jonathanpalma <tanpalma04@gmail.com>
Co-Authored-By: jonathanpalma <tanpalma04@gmail.com>
Co-Authored-By: jonathanpalma <tanpalma04@gmail.com>
@jonathanpalma
Copy link
Contributor Author

Hey @Darking360, thanks for your review, I already updated all the changes you recommended, could you please check again?

Copy link
Contributor

@icarlossz icarlossz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! I suggested a few changes and typos. Thanks.

content/docs/render-props.md Outdated Show resolved Hide resolved
content/docs/render-props.md Outdated Show resolved Hide resolved
content/docs/render-props.md Outdated Show resolved Hide resolved
content/docs/render-props.md Outdated Show resolved Hide resolved
content/docs/render-props.md Outdated Show resolved Hide resolved
Copy link
Member

@alejandronanez alejandronanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jonathanpalma!

Thanks for your contribution, I left some extra comments here that are worth addressing before merging!

This is looking great so far, thanks for all your hard work!

content/docs/render-props.md Outdated Show resolved Hide resolved
content/docs/render-props.md Outdated Show resolved Hide resolved
content/docs/render-props.md Outdated Show resolved Hide resolved
content/docs/render-props.md Outdated Show resolved Hide resolved
content/docs/render-props.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@Darking360 Darking360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greetings @jonathanpalma 🌞

Thanks for addressing the changes from the guys, I saw some markdown issues and an accent left but I added those so no worries 💪 Thanks for the great work, you rock! 🚀

@Darking360 Darking360 merged commit 95c345f into reactjs:master Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants