Codebase Overview Translation #186
Conversation
|
Deploy preview for es-reactjs ready! Built with commit b85fa04 |
There was a problem hiding this comment.
Greetings @jnosornov Thank you for a great PR, and all the hard work as well! 💪
I just left you some comments, most of them are just typos and accents, I added the feedback from @icarlossz as a code suggestion for you to add them in an easy way. Also I added comments to remove some extra lines in order to this document match perfectly the original one in order to not have conflicts with future changes or PRs 🚀
Please let me know any questions, or when you have those ready we'd be good to go. Thanks again! 🥇
|
Hey Johnathan! Could you check all the comments? I think you were missing a few, and if you could go saying in the comments what you've already done would be helpful. Thanks a lot for your contribution! 👾 |
|
Greetings @jnosornov 🌞 As @icarlossz mentioned, there are some comments that were not addressed with your update, please check them all and ping us again, please 🚀 |
|
What's good guys, @icarlossz @Darking360 managed to add the changes, missed some because they were not underlined in the comment suggestion. If there are more just let me know. |
|
Hey @jnosornov 💪 I saw that too in some other PRs but I really don't know why. What I do know is that you can commit directly with the comment, if you open the options for the current comment there will be an option for adding the code suggestions directly, you can take a look to this link so you can add the comments left, there are around 22 comments unresolved, you can try with that, is really easy and pretty straight forward 🚀 Let us know for any questions 🤓 |
Co-Authored-By: jnosornov <jnosornov@gmail.com>
|
Oh jeez, missed commits were hidden by default. @Darking360 thanks for the advice, but if you commit directly from the suggestion, you will have to do it for everyone of them, straight forward |
There was a problem hiding this comment.
Hey @jnosornov I just reopened the ones that I don't see added, try to see them inside the Files changed tab here in Github, also you should check if you committed those changes, maybe you didn't is possible too. Check those and let me know 💪
|
@jnosornov Make sure to check inside the |
|
mmm @Darking360 yeah you are right, I have not committed those changes yet, just have them locally. Changes would be shipped by today night. |
…es.reactjs.org into codebase-overview-translation
|
@Darking360 all changes have been added, even the last requested. Let me know if further changes are needed. I hope there are no more XD, this PR was massive. |
There was a problem hiding this comment.
Greetings @jnosornov 🌤
That's nice, thanks a bunch for your work and updating the PR, I'm really glad that we could learn something together and contribute to the documentation 💪 I just added a little fixes but were just translating code comments and an accent left, so no worries there. You rock dude! 🚀
Thanks a lot again 🙏
|
All right @Darking360, if more changes are needed just open more suggestions, I'll be more than happy to contribute. |
This is the PR for Codebase Overview