Using the Effect Hook #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 @escorponox welcome to this project. Is this your PR still in progress? I see a lot of translated content but the title says Thanks! |
|
There is still a lot of content to be translated. I will remove the [WIP] once it is finished. Thanks!!! |
added 2 commits
February 5, 2019 12:22
|
Ready for review. @alejandronanez @carburo @dmoralesm |
carburo
requested changes
Feb 7, 2019
Co-Authored-By: escorponox <escorponox@gmail.com>
Co-Authored-By: escorponox <escorponox@gmail.com>
Co-Authored-By: escorponox <escorponox@gmail.com>
Co-Authored-By: escorponox <escorponox@gmail.com>
Co-Authored-By: escorponox <escorponox@gmail.com>
Co-Authored-By: escorponox <escorponox@gmail.com>
Co-Authored-By: escorponox <escorponox@gmail.com>
Co-Authored-By: escorponox <escorponox@gmail.com>
|
@carburo I think all issues are fixed. |
content/docs/hooks-effect.md
Outdated
| > | ||
| >Eagle-eyed readers may notice that this example also needs a `componentDidUpdate` method to be fully correct. We'll ignore this for now but will come back to it in a [later section](#explanation-why-effects-run-on-each-update) of this page. | ||
| >Los lectores avispados podrán percatarse de que este ejemplo necesita también un método `componentDidUpdate` para ser completamente correcto. De momento vamos a ignorar este hecho, pero volveremos a él en una [sección posterior](#explanation-why-effects-run-on-each-update) de esta página. |
There was a problem hiding this comment.
No biggie, but I think that detallistas sounds a bit better than avispados.
What do you think?
Suggested change
| >Los lectores avispados podrán percatarse de que este ejemplo necesita también un método `componentDidUpdate` para ser completamente correcto. De momento vamos a ignorar este hecho, pero volveremos a él en una [sección posterior](#explanation-why-effects-run-on-each-update) de esta página. | |
| >Los lectores detallistas podrán percatarse de que este ejemplo necesita también un método `componentDidUpdate` para ser completamente correcto. De momento vamos a ignorar este hecho, pero volveremos a él en una [sección posterior](#explanation-why-effects-run-on-each-update) de esta página. |
There was a problem hiding this comment.
perspicaces may fit better imho. Do you agree? detallista is used for personal relationships in Spain
carburo
approved these changes
Feb 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.