Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation of "Hooks at a Glance" page #70

Merged
merged 6 commits into from
Feb 8, 2019

Conversation

GiuMagnani
Copy link
Contributor

@GiuMagnani GiuMagnani commented Feb 4, 2019

Copy link
Member

@alejandronanez alejandronanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @GiuMagnani, thanks for your hard work here, this is getting super close to what we need! 🙌

I left a couple of suggestions that should be addressed before merging this!

Thanks a lot!

content/docs/hooks-overview.md Outdated Show resolved Hide resolved
content/docs/hooks-overview.md Outdated Show resolved Hide resolved
alejandronanez and others added 2 commits February 4, 2019 22:44
Fix missed "Hooks"

Co-Authored-By: GiuMagnani <glmagnani@gmail.com>
Fixed wrong translation for "Effect Hook".

Co-Authored-By: GiuMagnani <glmagnani@gmail.com>
@GiuMagnani
Copy link
Contributor Author

Thanks @alejandronanez for the corrections! I already committed them. Let me know if there is anything else.

Copy link
Member

@alejandronanez alejandronanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work as always @GiuMagnani!

Thank you very much!

Copy link
Member

@alejandronanez alejandronanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GiuMagnani, oops, it seems that you have some merge conflicts on your branch.

Please, fix them and this will be ready to merge!

@GiuMagnani
Copy link
Contributor Author

@alejandronanez I'll take a look, thanks!

@carburo carburo merged commit b726491 into reactjs:master Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants