Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing-jsx translated #8

Merged
merged 4 commits into from
Feb 3, 2019
Merged

Conversation

icarlossz
Copy link
Contributor

Introducing JSX translation.
Related to #4

I start with the spanish translation according to the second task of the pull request.
@icarlossz icarlossz changed the title WIP: Introducing-jsx translation Introducing-jsx translated Feb 1, 2019
Copy link
Member

@alejandronanez alejandronanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @icarlossz, thanks for working on this translation!

This is looking good so far, I left some comments regarding some changes that should be addressed before merging this.

Thanks again!

content/docs/introducing-jsx.md Outdated Show resolved Hide resolved
content/docs/introducing-jsx.md Outdated Show resolved Hide resolved
content/docs/introducing-jsx.md Outdated Show resolved Hide resolved
content/docs/introducing-jsx.md Outdated Show resolved Hide resolved
Copy link
Member

@alejandronanez alejandronanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing our previous comments!

@alejandronanez alejandronanez merged commit 700eb11 into reactjs:master Feb 3, 2019
@icarlossz
Copy link
Contributor Author

you're welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants