Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate Tutorial #83

Merged
merged 30 commits into from
Feb 15, 2019
Merged

Conversation

ivandevp
Copy link
Contributor

@ivandevp ivandevp commented Feb 5, 2019

I have a doubt for how to translate time travel, I think it should remain in English, any suggestions?

@alejandronanez
Copy link
Member

Hey @ivandevp, this is a tough one!

I'd say viajar en el tiempo, in this context I think it could be something like [Agregando viajes en el tiempo], does that sound good to you?

@ivandevp
Copy link
Contributor Author

ivandevp commented Feb 7, 2019

Hey @alejandronanez, thanks for your answer. Yeah, I think that could be the right translation. Basically, I thought it's a keyword so used in dev and job environment, that's why I suggested to keep it in English, but if you think it's better understandable in Spanish, I'll go for it. Thanks again!

- id: what-are-we-building
title: What Are We Building?
href: /tutorial/tutorial.html#what-are-we-building
- id: que-estamos-construyendo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please leave the ids untranslated

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, got it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@ivandevp
Copy link
Contributor Author

Hey @tesseralis @alejandronanez ! When pulling changes from upstream, navigation ids were added to the markdown in all headings. I'm not sure how that works, but those are seen in the rendered page:

screen shot 2019-02-11 at 9 38 43 am

Are they going to be hidden in build step or it's a bug and we need to fix it?

@tesseralis
Copy link
Member

@ivan yup, that's how they work. They're not supported in the github viewer but we added a plugin so they're supported in the site!

@ivandevp
Copy link
Contributor Author

Great! Thanks for your reply @tesseralis.

@ivandevp ivandevp changed the title [WIP] Translate Tutorial Translate Tutorial Feb 12, 2019
@ivandevp
Copy link
Contributor Author

Hey guys! I finished translating the tutorial (it was really long 😅). I took some assumptions that I want to confirm with you if are ok, I know about the TRANSLATIONS.md file and got some interesting topics specially for this translation. I didn't change any naming component, function, variable in the code, the reason for this is that the tutorial refers to a starter boilerplate created by Dan Abramov, I think that translating naming references will make things confusing instead of clarity. Let me know what do you think when getting a chance.

@alejandronanez
Copy link
Member

Hey @ivandevp, thanks for all the hard work!

I’ll take a look at this tomorrow night!

Thanks again!!!!

content/tutorial/nav.yml Outdated Show resolved Hide resolved
Copy link
Member

@alejandronanez alejandronanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ivandevp, thanks for your PR - this is a huge document, thanks for taking the time to work on it!

I requested a few changes here before merging, please, let me (us) know if you need any help or if something is not clear enough!

Thanks again!

content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
@ivandevp
Copy link
Contributor Author

Great review @alejandronanez ! Thanks for all the comments left, I've just updated the fixes, let me know if we should improve anything else, please.

Copy link
Member

@alejandronanez alejandronanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey again @ivandevp,

Thanks for addressing all the comments so quickly - what an awesome job you've done here, this was a huuuge PR, thanks for all the hard work.

This is looking good to merge!

Welcome to the project! 🎉

@alejandronanez alejandronanez merged commit 235fad4 into reactjs:master Feb 15, 2019
@ivandevp
Copy link
Contributor Author

Awesome! Great news to see @alejandronanez ! I would like to contribute more, I have a little bit of free time, even if I can help maintaining the repo is an option if needed. Let me know how else may I help when you can.

@ivandevp ivandevp deleted the translate/tutorial branch February 15, 2019 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants