Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate integrating-with-other-libraries #117

Merged

Conversation

thayashi
Copy link
Contributor

This PR is part of Issue #4.

@thayashi thayashi closed this Feb 12, 2019
@thayashi thayashi reopened this Feb 12, 2019
@thayashi thayashi force-pushed the tr/integrating-with-other-libraries branch from 9d8dde4 to 86370ea Compare February 12, 2019 23:12
@thayashi
Copy link
Contributor Author

How I can assign @smikitky as a reviewer?

@smikitky smikitky self-requested a review February 13, 2019 03:06
@smikitky
Copy link
Member

Sorry, that was possible for someone with write access. Edited the instruction.

@smikitky smikitky added the 🚫 in intial review 初期レビューの真っ最中 label Feb 13, 2019
Copy link
Member

@smikitky smikitky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

レビューしました。大部分は訳語統一や軽微な誤字になりますのでご確認いただけますでしょうか。

content/docs/integrating-with-other-libraries.md Outdated Show resolved Hide resolved
content/docs/integrating-with-other-libraries.md Outdated Show resolved Hide resolved
content/docs/integrating-with-other-libraries.md Outdated Show resolved Hide resolved
content/docs/integrating-with-other-libraries.md Outdated Show resolved Hide resolved
content/docs/integrating-with-other-libraries.md Outdated Show resolved Hide resolved
content/docs/integrating-with-other-libraries.md Outdated Show resolved Hide resolved
content/docs/integrating-with-other-libraries.md Outdated Show resolved Hide resolved
content/docs/integrating-with-other-libraries.md Outdated Show resolved Hide resolved
content/docs/integrating-with-other-libraries.md Outdated Show resolved Hide resolved
@smikitky smikitky removed the 🚫 in intial review 初期レビューの真っ最中 label Feb 13, 2019
@tesseralis tesseralis mentioned this pull request Feb 13, 2019
90 tasks
@thayashi thayashi force-pushed the tr/integrating-with-other-libraries branch from 86370ea to 3bfde13 Compare February 13, 2019 18:19
@thayashi
Copy link
Contributor Author

@smikitky レビューありがとうございました。もろもろ修正しましたのでご確認ください。

Copy link
Member

@potato4d potato4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

良さそうに見えます

@thayashi thayashi force-pushed the tr/integrating-with-other-libraries branch from 6bb94e7 to 527e116 Compare February 16, 2019 20:41
Copy link
Member

@smikitky smikitky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

すみません1か所だけミスを見つけました

content/docs/integrating-with-other-libraries.md Outdated Show resolved Hide resolved
@thayashi thayashi force-pushed the tr/integrating-with-other-libraries branch from 527e116 to 05c7ac3 Compare February 18, 2019 17:21
@smikitky smikitky merged commit ff9b6aa into reactjs:master Feb 18, 2019
@smikitky
Copy link
Member

ありがとうございました!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants