Optimizing performance #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uehaj
force-pushed
the
optimizing-performance
branch
from
257bc66
to
401ec03
Compare
uehaj
force-pushed
the
optimizing-performance
branch
from
d90fea0
to
fb79320
Compare
smikitky
requested changes
Feb 25, 2019
90 tasks
Co-Authored-By: uehaj <59012+uehaj@users.noreply.github.com>
Co-Authored-By: uehaj <59012+uehaj@users.noreply.github.com>
Co-Authored-By: uehaj <59012+uehaj@users.noreply.github.com>
Co-Authored-By: uehaj <59012+uehaj@users.noreply.github.com>
Co-Authored-By: uehaj <59012+uehaj@users.noreply.github.com>
Co-Authored-By: uehaj <59012+uehaj@users.noreply.github.com>
Co-Authored-By: uehaj <59012+uehaj@users.noreply.github.com>
Co-Authored-By: uehaj <59012+uehaj@users.noreply.github.com>
|
Deploy preview for ja-reactjs ready! Built with commit ddf7100 |
Co-Authored-By: uehaj <59012+uehaj@users.noreply.github.com>
Co-Authored-By: uehaj <59012+uehaj@users.noreply.github.com>
Co-Authored-By: uehaj <59012+uehaj@users.noreply.github.com>
|
Deploy preview for ja-reactjs ready! Built with commit 22a0825 |
|
Deploy preview for ja-reactjs ready! Built with commit 1faf91f |
Co-Authored-By: uehaj <59012+uehaj@users.noreply.github.com>
Co-Authored-By: uehaj <59012+uehaj@users.noreply.github.com>
Co-Authored-By: uehaj <59012+uehaj@users.noreply.github.com>
…reactjs.org into optimizing-performance
レビューいただきありがとうございます。修正しました。改行については今後も英文版とdiff常にとるように留意します。よろしくおねがいします。 |
Co-Authored-By: uehaj <59012+uehaj@users.noreply.github.com>
Co-Authored-By: uehaj <59012+uehaj@users.noreply.github.com>
Co-Authored-By: uehaj <59012+uehaj@users.noreply.github.com>
Co-Authored-By: uehaj <59012+uehaj@users.noreply.github.com>
Co-Authored-By: uehaj <59012+uehaj@users.noreply.github.com>
Co-Authored-By: uehaj <59012+uehaj@users.noreply.github.com>
Co-Authored-By: uehaj <59012+uehaj@users.noreply.github.com>
|
ここまで確認しました。4箇所不必要な改行（ないし
|
smikitky
requested changes
Mar 6, 2019
smikitky
approved these changes
Mar 6, 2019
|
よさそうです、ありがとうございました！ |
koba04
approved these changes
Mar 6, 2019
|
@uehaj mergeしました！ 🚀 ありがとうございます！！ 🎉🎉🎉 |
|
ありがとうございました! もう他には翻訳未着手はないですね。(ほぼ)おめでとうございます! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of Issue #4.
レビューを宜しくお願いします。