Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate hooks-intro #18

Merged
merged 7 commits into from
Feb 2, 2019
Merged

Translate hooks-intro #18

merged 7 commits into from
Feb 2, 2019

Conversation

smikitky
Copy link
Member

@smikitky smikitky commented Feb 1, 2019

This is the first PR for the translation for Hooks.

Note: Currently React 16.8 is scheduled to be out on February 4th, which mean this article may be out of date VERY soon. So we may not have to be too strict on the quality.

@tesseralis tesseralis mentioned this pull request Feb 1, 2019
90 tasks
Copy link
Member

@potato4d potato4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smikitky
翻訳お疲れ様です。いくつかコメントをしたのでご確認いただけると幸いです!
また、これから Hooks が広く使われる可能性はありますので、 #3 に Hooks についての取扱もあわせて入れることを検討しましょうか。

content/docs/hooks-intro.md Outdated Show resolved Hide resolved
content/docs/hooks-intro.md Outdated Show resolved Hide resolved
content/docs/hooks-intro.md Show resolved Hide resolved
Co-Authored-By: smikitky <smiki-tky@umin.ac.jp>
Copy link
Member

@potato4d potato4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

良いと思います 👍

@koba04 koba04 self-requested a review February 2, 2019 10:39
Copy link
Member

@koba04 koba04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

細かい点ですが、いくつかコメントしておきました。

content/docs/hooks-intro.md Outdated Show resolved Hide resolved
content/docs/hooks-intro.md Outdated Show resolved Hide resolved
content/docs/hooks-intro.md Outdated Show resolved Hide resolved
content/docs/hooks-intro.md Outdated Show resolved Hide resolved
content/docs/hooks-intro.md Outdated Show resolved Hide resolved
content/docs/hooks-intro.md Outdated Show resolved Hide resolved
content/docs/hooks-intro.md Outdated Show resolved Hide resolved
koba04 and others added 2 commits February 2, 2019 21:05
Co-Authored-By: smikitky <smiki-tky@umin.ac.jp>
@smikitky
Copy link
Member Author

smikitky commented Feb 2, 2019

@potato4d @koba04 ありがとうございました!

@smikitky smikitky merged commit 83bc3bb into master Feb 2, 2019
@koba04 koba04 deleted the tr/hooks-intro branch February 2, 2019 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants