-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate composition-vs-inheritance #5
Translate composition-vs-inheritance #5
Conversation
ありがとうございます! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed and made comment on on point.
Please check and reply it!
それはそれとして、日本語訳のレビューは日本語の話も多くなると思うので、 PR へのレビューコメントは日本語ベースで良いかなぁと思ったりしていますが、みなさんどうでしょう。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
よさそうだと思います。対応ありがとうございます!
@potato4d 文末のコロンの有無についてご意見はありますか? 原文がコロンで終わっていても |
@smikitky |
@@ -80,13 +80,13 @@ function App() { | |||
|
|||
[**Try it on CodePen**](https://codepen.io/gaearon/pen/gwZOJp?editors=0010) | |||
|
|||
React elements like `<Contacts />` and `<Chat />` are just objects, so you can pass them as props like any other data. This approach may remind you of "slots" in other libraries but there are no limitations on what you can pass as props in React. | |||
`<Contacts />` や `<Chat />` のような React の要素はただのオブジェクトなので、他のあらゆるデータと同様に `props` として渡すことができます。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"This approach may remind you of “slots” in other libraries but there are no limitations on what you can pass as props in React." の訳が抜けています
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
見逃していました。該当部分を追記致しました。また、日本のエンジニアならVue, Angular以外にもRails(Riot.jsというケース) からくる人も多いと思うので、 slot に該当する yield も例として追加しました。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
すみません、いくつか訳抜けや疑問点を発見したので対応をお願い致します。
レビューありがとうございます! |
@saitoeku3 |
…to translate/composition-vs-inheritance
Text Lintかけて指摘箇所を直しました:pray: |
This PR is part of Issue #4
I've translated the composition-vs-inheritance document to Japanese, based on translation on crowdin.