Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate test-utils #57

Merged
merged 17 commits into from
Feb 25, 2019
Merged

Translate test-utils #57

merged 17 commits into from
Feb 25, 2019

Conversation

takanorip
Copy link
Contributor

@takanorip takanorip commented Feb 3, 2019 •
edited
Loading

Please review.

@takanorip takanorip changed the title add translation Translate test-utils Feb 3, 2019
@smikitky smikitky self-requested a review February 4, 2019 00:48
@koba04 koba04 self-requested a review February 4, 2019 01:18
sasurau4
sasurau4 suggested changes Feb 4, 2019
View reviewed changes
Copy link
Contributor

@sasurau4 sasurau4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

翻訳ありがとうございます 👍
細かいスタイルの指摘をしました。よろしくお願いします 🙏

content/docs/addons-test-utils.md Outdated Show resolved Hide resolved
content/docs/addons-test-utils.md Outdated Show resolved Hide resolved
content/docs/addons-test-utils.md Outdated Show resolved Hide resolved
content/docs/addons-test-utils.md Outdated Show resolved Hide resolved
content/docs/addons-test-utils.md Outdated Show resolved Hide resolved
content/docs/addons-test-utils.md Outdated Show resolved Hide resolved
content/docs/addons-test-utils.md Outdated Show resolved Hide resolved
content/docs/addons-test-utils.md Outdated Show resolved Hide resolved
content/docs/addons-test-utils.md Outdated Show resolved Hide resolved
content/docs/addons-test-utils.md Outdated Show resolved Hide resolved
@smikitky
Copy link
Member

smikitky commented Feb 4, 2019

まだ文の中身まで追えていませんが、とりあえず原文で改行がないのに翻訳で勝手に改行が入っているところが散見されますので修正をお願いします。

@takanorip
Copy link
Contributor Author

改行は改行として解釈されるんですね。変更します。

@koba04 koba04 removed their request for review February 4, 2019 09:42
sasurau4
sasurau4 approved these changes Feb 5, 2019
View reviewed changes
Copy link
Contributor

@sasurau4 sasurau4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀
他のwrite権限持ってる人のレビューをお待ちください 🙏

@tesseralis tesseralis mentioned this pull request Feb 5, 2019
Closed
90 tasks
koba04
koba04 requested changes Feb 6, 2019
View reviewed changes
Copy link
Member

@koba04 koba04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@takanorip いくつかコメントしたので確認お願いします！🙇‍♂️

content/docs/addons-test-utils.md Outdated Show resolved Hide resolved
content/docs/addons-test-utils.md Outdated Show resolved Hide resolved
content/docs/addons-test-utils.md Outdated Show resolved Hide resolved
content/docs/addons-test-utils.md Outdated Show resolved Hide resolved
content/docs/addons-test-utils.md Outdated Show resolved Hide resolved
content/docs/addons-test-utils.md Show resolved Hide resolved
content/docs/addons-test-utils.md Outdated Show resolved Hide resolved
@smikitky
Copy link
Member

smikitky commented Feb 7, 2019

先週のフォークから1週間で起きた upstream (本家 reactjs.org) の更新がもうすぐマージされます。
この記事に関わる原文の変更もあります。
#91 の差分を見て、翻訳の反映をお願いできますでしょうか。

koba04 and others added 3 commits February 8, 2019 00:09
@koba04 @takanorip
Update content/docs/addons-test-utils.md
9cac3d4 
Co-Authored-By: takanorip <takanori0170@gmail.com>
@koba04 @takanorip
Update content/docs/addons-test-utils.md
3730b69 
Co-Authored-By: takanorip <takanori0170@gmail.com>
@takanorip
Update addons-test-utils.md
2b00e1c
@tesseralis
Copy link
Member

@takanorip could you fix the merge conflicts that are showing up?
@koba04 I think this might be ready for another review?

@koba04
Copy link
Member

koba04 commented Feb 12, 2019

@tesseralis Yes, I could approve this PR after fixing the merge conflicts.

@takanorip
Copy link
Contributor Author

I will fix it tomorrow or day after tomorrow.

smikitky
smikitky requested changes Feb 18, 2019
View reviewed changes
Copy link
Member

@smikitky smikitky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

遅くなり申し訳ありません。訳文はほぼ問題ないと思うのですが、コード中に全角文字があったり、原文と記載の順番が変わってしまっている部分がいくつか見つかりましたので対応をお願いします。また スペース絡みの問題については textlint でエラーが出ているのを修正すればだいたい直りますので確認をお願いします。あとこのあたりのコードは自分自身が不慣れなので、もし変な指摘があったら遠慮なく仰ってください。

content/docs/addons-test-utils.md Outdated Show resolved Hide resolved
content/docs/addons-test-utils.md Show resolved Hide resolved
content/docs/addons-test-utils.md Outdated Show resolved Hide resolved
content/docs/addons-test-utils.md Show resolved Hide resolved
content/docs/addons-test-utils.md Outdated Show resolved Hide resolved
content/docs/addons-test-utils.md Outdated Show resolved Hide resolved
content/docs/addons-test-utils.md Outdated Show resolved Hide resolved
@potato4d
Copy link
Member

@takanorip
こちらいかがでしょうか 🙏

@potato4d
Copy link
Member

@takanorip
難しければ引き継ぎますので、ご連絡ください！

smikitky and others added 4 commits February 25, 2019 03:49
@smikitky @takanorip
Update content/docs/addons-test-utils.md
b36b211 
Co-Authored-By: takanorip <takanori0170@gmail.com>
@smikitky @takanorip
Update content/docs/addons-test-utils.md
13dd2d0 
Co-Authored-By: takanorip <takanori0170@gmail.com>
@smikitky @takanorip
Update content/docs/addons-test-utils.md
10ece8c 
Co-Authored-By: takanorip <takanori0170@gmail.com>
@smikitky @takanorip
Update content/docs/addons-test-utils.md
369bcf4 
Co-Authored-By: takanorip <takanori0170@gmail.com>
@netlify
Copy link

netlify bot commented Feb 24, 2019

Deploy preview for ja-reactjs ready!

Built with commit b36b211

https://deploy-preview-57--ja-reactjs.netlify.com

@netlify
Copy link

netlify bot commented Feb 24, 2019

Deploy preview for ja-reactjs ready!

Built with commit 5f7a008

https://deploy-preview-57--ja-reactjs.netlify.com

@netlify
Copy link

netlify bot commented Feb 24, 2019 •
edited
Loading

Deploy preview for ja-reactjs ready!

Built with commit 212ba50

https://deploy-preview-57--ja-reactjs.netlify.com

potato4d
potato4d approved these changes Feb 25, 2019
View reviewed changes
Copy link
Member

@potato4d potato4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

よさそうですー！お疲れ様でした！

@smikitky smikitky merged commit e73ac76 into reactjs:master Feb 25, 2019
@smikitky
Copy link
Member

マージしました、ありがとうございましたー

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koba04 koba04 koba04 requested changes

@sasurau4 sasurau4 sasurau4 approved these changes

@smikitky smikitky smikitky approved these changes

@potato4d potato4d potato4d approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@takanorip @smikitky @tesseralis @koba04 @potato4d @sasurau4