Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate strict-mode.md to pt-BR #25

Merged
merged 18 commits into from
Feb 10, 2019
Merged

Translate strict-mode.md to pt-BR #25

merged 18 commits into from
Feb 10, 2019

Conversation

lffg
Copy link
Contributor

@lffg lffg commented Feb 9, 2019 •
edited
Loading

Ref: #1

@cezaraugusto cezaraugusto added the needs review A pull request ready to be reviewed label Feb 9, 2019
cezaraugusto
cezaraugusto requested changes Feb 9, 2019
View reviewed changes
Copy link
Member

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @lffg great translation! left some comments regarding some known words that I'd like to keep

content/docs/strict-mode.md Outdated Show resolved Hide resolved
content/docs/strict-mode.md Outdated Show resolved Hide resolved
content/docs/strict-mode.md Outdated Show resolved Hide resolved
content/docs/strict-mode.md Outdated Show resolved Hide resolved
content/docs/strict-mode.md Outdated Show resolved Hide resolved
content/docs/strict-mode.md Outdated Show resolved Hide resolved
content/docs/strict-mode.md Outdated Show resolved Hide resolved
content/docs/strict-mode.md Outdated Show resolved Hide resolved
@cezaraugusto cezaraugusto added needs author response Changes requested needing author's input and removed needs review A pull request ready to be reviewed labels Feb 9, 2019
@lffg
Copy link
Contributor Author

lffg commented Feb 9, 2019

Done! ;)

@lffg lffg mentioned this pull request Feb 9, 2019
Closed
90 tasks
cezaraugusto
cezaraugusto previously approved these changes Feb 9, 2019
View reviewed changes
Copy link
Member

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work @lffg, approving. thanks!

@cezaraugusto cezaraugusto added needs +1 Needs another approval before merging and removed needs author response Changes requested needing author's input labels Feb 9, 2019
fjoshuajr
fjoshuajr requested changes Feb 9, 2019
View reviewed changes
Copy link
Collaborator

@fjoshuajr fjoshuajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check these suggestions please.

content/docs/strict-mode.md Show resolved Hide resolved
content/docs/strict-mode.md Outdated Show resolved Hide resolved
content/docs/strict-mode.md Outdated Show resolved Hide resolved
content/docs/strict-mode.md Outdated Show resolved Hide resolved
content/docs/strict-mode.md Outdated Show resolved Hide resolved
content/docs/strict-mode.md Outdated Show resolved Hide resolved
content/docs/strict-mode.md Outdated Show resolved Hide resolved
content/docs/strict-mode.md Outdated Show resolved Hide resolved
content/docs/strict-mode.md Outdated Show resolved Hide resolved
content/docs/strict-mode.md Show resolved Hide resolved
@cezaraugusto cezaraugusto added needs author response Changes requested needing author's input and removed needs +1 Needs another approval before merging labels Feb 9, 2019
@fjoshuajr @lffg
"usando ciclo" -> "que usam ciclos"
5f63f89 
Co-Authored-By: lffg <23662020+lffg@users.noreply.github.com>
fjoshuajr and others added 14 commits February 9, 2019 19:46
@fjoshuajr @lffg
"Avisos" -> "Aviso"
928ba50 
Co-Authored-By: lffg <23662020+lffg@users.noreply.github.com>
@fjoshuajr @lffg
"lado negativo" -?
8d14be2 
Co-Authored-By: lffg <23662020+lffg@users.noreply.github.com>
@fjoshuajr @lffg
https://github.com/reactjs/pt-BR.reactjs.org/pull/25#discussion_r2553…
3fac65b 
…11412

Co-Authored-By: lffg <23662020+lffg@users.noreply.github.com>
@fjoshuajr @lffg
https://github.com/reactjs/pt-BR.reactjs.org/pull/25#discussion_r2553…
0305b3c 
…11521

Co-Authored-By: lffg <23662020+lffg@users.noreply.github.com>
@fjoshuajr @lffg
https://github.com/reactjs/pt-BR.reactjs.org/pull/25#discussion_r2553…
5af8be3 
…11552

Co-Authored-By: lffg <23662020+lffg@users.noreply.github.com>
@fjoshuajr @lffg
https://github.com/reactjs/pt-BR.reactjs.org/pull/25#discussion_r2553…
8eb795a 
…11702

Co-Authored-By: lffg <23662020+lffg@users.noreply.github.com>
@fjoshuajr @lffg
https://github.com/reactjs/pt-BR.reactjs.org/pull/25#discussion_r2553…
7c155a9 
…13209

Co-Authored-By: lffg <23662020+lffg@users.noreply.github.com>
@fjoshuajr @lffg
https://github.com/reactjs/pt-BR.reactjs.org/pull/25#discussion_r2553…
79a93f7 
…12979

Co-Authored-By: lffg <23662020+lffg@users.noreply.github.com>
@fjoshuajr @lffg
https://github.com/reactjs/pt-BR.reactjs.org/pull/25#discussion_r2553…
cb24338 
…11767

Co-Authored-By: lffg <23662020+lffg@users.noreply.github.com>
@fjoshuajr @lffg
https://github.com/reactjs/pt-BR.reactjs.org/pull/25#discussion_r2553…
dc7bf1c 
…11785

Co-Authored-By: lffg <23662020+lffg@users.noreply.github.com>
@fjoshuajr @lffg
https://github.com/reactjs/pt-BR.reactjs.org/pull/25#discussion_r2553…
12828e8 
…11989

Co-Authored-By: lffg <23662020+lffg@users.noreply.github.com>
@fjoshuajr @lffg
https://github.com/reactjs/pt-BR.reactjs.org/pull/25#discussion_r2553…
e0d5b8b 
…12150

Co-Authored-By: lffg <23662020+lffg@users.noreply.github.com>
@fjoshuajr @lffg
https://github.com/reactjs/pt-BR.reactjs.org/pull/25#discussion_r2553…
9c8ae68 
…12181

Co-Authored-By: lffg <23662020+lffg@users.noreply.github.com>
@fjoshuajr @lffg
https://github.com/reactjs/pt-BR.reactjs.org/pull/25#discussion_r2553…
dd95b82 
…12228

Co-Authored-By: lffg <23662020+lffg@users.noreply.github.com>
@lffg
Copy link
Contributor Author

lffg commented Feb 9, 2019 •
edited
Loading

@fjoshuajr, obrigado pelas notas! Corrigi aquelas sugestões que pensei serem aplicáveis. Por favor, veja os meus comentários em certas sugestões para verificar as minhas notas.

P.S.: Estou escrevendo em português para facilitar a comunicação, assim como está sendo feito em outros repositórios de tradução. Se houver algum problema nisso, por favor, avisem-me. :)

@fjoshuajr
Copy link
Collaborator

@fjoshuajr, obrigado pelas notas! Corrigi aquelas sugestões que pensei serem aplicáveis. Por favor, veja os meus comentários em certas sugestões para verificar as minhas notas.

P.S.: Estou escrevendo em português para facilitar a comunicação, assim como está sendo feito em outros repositórios de tradução. Se houver algum problema nisso, por favor, avisem-me. :)

Tudo bem, vou verificar.

fjoshuajr
fjoshuajr approved these changes Feb 9, 2019
View reviewed changes
Copy link
Collaborator

@fjoshuajr fjoshuajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beleza! LGTM 🎉

content/docs/strict-mode.md Show resolved Hide resolved
@fjoshuajr fjoshuajr added needs +1 Needs another approval before merging and removed needs author response Changes requested needing author's input labels Feb 9, 2019
glaucia86
glaucia86 approved these changes Feb 10, 2019
View reviewed changes
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lffg
LGTM 👍
Queremos agradecer pela sua excelente contribuição! Muito obrigada!

@glaucia86 glaucia86 merged commit c964771 into reactjs:master Feb 10, 2019
@glaucia86 glaucia86 removed the needs +1 Needs another approval before merging label Feb 10, 2019
@fjoshuajr fjoshuajr added the 🌐 translated Translation is completed for this page label Feb 10, 2019
@lffg lffg deleted the patch-1 branch February 10, 2019 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjoshuajr fjoshuajr fjoshuajr approved these changes

@glaucia86 glaucia86 glaucia86 approved these changes

@cezaraugusto cezaraugusto cezaraugusto left review comments

Assignees
No one assigned
Labels
🌐 translated Translation is completed for this page
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lffg @fjoshuajr @glaucia86 @cezaraugusto