Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate Fragment.md #680

Merged
merged 6 commits into from
May 22, 2023
Merged

Translate Fragment.md #680

merged 6 commits into from
May 22, 2023

Conversation

kevinCubas
Copy link
Contributor

Translate the Fragment component page:

Folder path: src\content\reference\react\Fragment.md

Notes:
Maintain Fragment and key without translation.

I would appreciate any sugestion or feedback for better pull requests in the future.

@kevinCubas kevinCubas changed the title Translate Fragment component Translate Fragment.md May 3, 2023
src/content/reference/react/Fragment.md Outdated Show resolved Hide resolved
src/content/reference/react/Fragment.md Outdated Show resolved Hide resolved
src/content/reference/react/Fragment.md Outdated Show resolved Hide resolved
buirkan
buirkan previously approved these changes May 8, 2023
jhonmike
jhonmike previously approved these changes May 10, 2023
Copy link
Member

@jhonmike jhonmike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apenas um comentario, obrigado pela tradução

src/content/reference/react/Fragment.md Show resolved Hide resolved
@jhonmike jhonmike added needs author response Changes requested needing author's input and removed needs review A pull request ready to be reviewed labels May 10, 2023
Co-authored-by: Jhon Mike <jhon.msdev@gmail.com>
@kevinCubas kevinCubas dismissed stale reviews from jhonmike and buirkan via 483beb5 May 10, 2023 16:48
@kevinCubas kevinCubas requested a review from jhonmike May 10, 2023 16:50
@jhonmike jhonmike added 🌐 translated Translation is completed for this page and removed needs author response Changes requested needing author's input labels May 10, 2023
jhonmike
jhonmike previously approved these changes May 10, 2023
@jhonmike jhonmike added the needs +1 Needs another approval before merging label May 10, 2023
@github-actions
Copy link

github-actions bot commented May 10, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@kevinCubas kevinCubas requested a review from buirkan May 10, 2023 17:09
buirkan
buirkan previously approved these changes May 10, 2023
@kevinCubas
Copy link
Contributor Author

Site Lint / Heading ID check / Lint on node 12.x and ubuntu-latest (pull_request)

Não passou esse check @jhonmike, é normal?

@jhonmike
Copy link
Member

Não é normal @kevinCubas vamos ter que verificar porque esta quebrando

@kevinCubas
Copy link
Contributor Author

Rodei os scripts:
yarn check-all
yarn fix-headings
yarn lint-heading-ids

Não consta nenhum erro localmente, revisei o documento e segue o padrão de contribuição.
Único arquivo com erro de heading id é: src\content\community\conferences.md

@jhonmike aguardo seu feedback.

@jhonmike jhonmike removed the needs +1 Needs another approval before merging label May 22, 2023
@jhonmike
Copy link
Member

atualiza a branch com a main, parece que a versão do node no package esta desatualizada

@jhonmike jhonmike merged commit 331206a into reactjs:main May 22, 2023
@kevinCubas kevinCubas deleted the kevincubas-translate-fragment branch May 23, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌐 translated Translation is completed for this page
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants