Revert "Unseal this.refs"

This reverts commit 72bc471. We'll just not seal `this.refs` in React versions with `warnAboutStringRefs`.
reactjs · Apr 24, 2024 · 5376b3b · 5376b3b
1 parent 4d37e63
commit 5376b3b
Show file tree

Hide file tree

Showing 5 changed files with 1 addition and 118 deletions.
diff --git a/README.md b/README.md
@@ -175,12 +175,6 @@ class ParentComponent extends React.Component {
     return (
       <div
         ref={(current) => {
-          if (process.env.NODE_ENV !== 'production') {
-            if (Object.isSealed(this.refs)) {
-              this.refs = {};
-            }
-          }
-
           this.refs["refComponent"] = current;
         }}
       />

diff --git a/transforms/__testfixtures__/string-refs/literal-with-owner.output.js b/transforms/__testfixtures__/string-refs/literal-with-owner.output.js
@@ -4,49 +4,19 @@ class ParentComponent extends React.Component {
   render() {
     return (
       <div ref={current => {
-        if (process.env.NODE_ENV !== 'production') {
-          if (Object.isSealed(this.refs)) {
-            this.refs = {};
-          }
-        }
-
         this.refs['P'] = current;
       }} id="P">
         <div ref={current => {
-          if (process.env.NODE_ENV !== 'production') {
-            if (Object.isSealed(this.refs)) {
-              this.refs = {};
-            }
-          }
-
           this.refs['P_P1'] = current;
         }} id="P_P1">
           <span ref={current => {
-            if (process.env.NODE_ENV !== 'production') {
-              if (Object.isSealed(this.refs)) {
-                this.refs = {};
-              }
-            }
-
             this.refs['P_P1_C1'] = current;
           }} id="P_P1_C1" />
           <span ref={current => {
-            if (process.env.NODE_ENV !== 'production') {
-              if (Object.isSealed(this.refs)) {
-                this.refs = {};
-              }
-            }
-
             this.refs['P_P1_C2'] = current;
           }} id="P_P1_C2" />
         </div>
         <div ref={current => {
-          if (process.env.NODE_ENV !== 'production') {
-            if (Object.isSealed(this.refs)) {
-              this.refs = {};
-            }
-          }
-
           this.refs['P_OneOff'] = current;
         }} id="P_OneOff" />
       </div>

diff --git a/transforms/__testfixtures__/string-refs/literal-without-owner.output.js b/transforms/__testfixtures__/string-refs/literal-without-owner.output.js
@@ -1,11 +1,5 @@
 import * as React from "react";
 
 <div ref={current => {
-  if (process.env.NODE_ENV !== 'production') {
-    if (Object.isSealed(this.refs)) {
-      this.refs = {};
-    }
-  }
-
   this.refs['bad'] = current;
 }} />;
diff --git a/transforms/__testfixtures__/string-refs/typescript/literal-with-owner.output.tsx b/transforms/__testfixtures__/string-refs/typescript/literal-with-owner.output.tsx
@@ -8,49 +8,19 @@ class ParentComponent extends React.Component {
   render() {
     return (
       <div ref={current => {
-        if (process.env.NODE_ENV !== 'production') {
-          if (Object.isSealed(this.refs)) {
-            this.refs = {};
-          }
-        }
-
         this.refs['P'] = current;
       }} id="P">
         <div ref={current => {
-          if (process.env.NODE_ENV !== 'production') {
-            if (Object.isSealed(this.refs)) {
-              this.refs = {};
-            }
-          }
-
           this.refs['P_P1'] = current;
         }} id="P_P1">
           <span ref={current => {
-            if (process.env.NODE_ENV !== 'production') {
-              if (Object.isSealed(this.refs)) {
-                this.refs = {};
-              }
-            }
-
             this.refs['P_P1_C1'] = current;
           }} id="P_P1_C1" />
           <span ref={current => {
-            if (process.env.NODE_ENV !== 'production') {
-              if (Object.isSealed(this.refs)) {
-                this.refs = {};
-              }
-            }
-
             this.refs['P_P1_C2'] = current;
           }} id="P_P1_C2" />
         </div>
         <div ref={current => {
-          if (process.env.NODE_ENV !== 'production') {
-            if (Object.isSealed(this.refs)) {
-              this.refs = {};
-            }
-          }
-
           this.refs['P_OneOff'] = current;
         }} id="P_OneOff" />
       </div>

diff --git a/transforms/string-refs.js b/transforms/string-refs.js
@@ -40,56 +40,11 @@ export default (file, api, options) => {
         // Maybe JSCodeShift has such a helper as well?
         const currentIdentifierName = "current";
         valuePath.replace(
-          // {(current) => {}}
+          // {(current) => { this.refs[valuePath.node.value] = current }}
           j.jsxExpressionContainer(
             j.arrowFunctionExpression(
               [j.identifier(currentIdentifierName)],
               j.blockStatement([
-                // if (process.env.NODE_ENV !== 'production')
-                j.ifStatement(
-                  j.binaryExpression(
-                    "!==",
-                    j.memberExpression(
-                      j.memberExpression(
-                        j.identifier("process"),
-                        j.identifier("env")
-                      ),
-                      j.identifier("NODE_ENV")
-                    ),
-                    j.stringLiteral("production")
-                  ),
-                  j.blockStatement([
-                    // if (Object.isSealed(this.refs))
-                    j.ifStatement(
-                      j.callExpression(
-                        j.memberExpression(
-                          j.identifier("Object"),
-                          j.identifier("isSealed")
-                        ),
-                        [
-                          j.memberExpression(
-                            j.thisExpression(),
-                            j.identifier("refs")
-                          ),
-                        ]
-                      ),
-                      j.blockStatement([
-                        // this.refs = {}
-                        j.expressionStatement(
-                          j.assignmentExpression(
-                            "=",
-                            j.memberExpression(
-                              j.thisExpression(),
-                              j.identifier("refs")
-                            ),
-                            j.objectExpression([])
-                          )
-                        ),
-                      ])
-                    ),
-                  ])
-                ),
-                // this.refs[valuePath.node.value] = current
                 j.expressionStatement(
                   j.assignmentExpression(
                     "=",