Add rename-unsafe-lifecycles codemod #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This codemod accompanies React RFC 6. Learn more about it here reactjs/rfcs#6
bvaughn
changed the title
|
Will new lifecycle names be landed in near minor version? |
31 tasks
|
Yup. Work-in-progress PR @ facebook/react/pull/12028 |
flarnie
approved these changes
Jan 18, 2018
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This codemod corresponds with reactjs/rfcs/pull/6 and facebook/react/pull/12028
This codemod was tested in the React repo by running:
jscodeshift \ -t ../react-codemod/transforms/rename-unsafe-lifecycles.js \ --parser=flow \ ./packages/**/src/**/*.jsI also ran this codemod internally on
fbsourceand it seemed to work okay, except for a single parse error (before the transform was applied).