Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use var instead of let #17

Merged
merged 1 commit into from
Apr 10, 2018
Merged

Use var instead of let #17

merged 1 commit into from
Apr 10, 2018

Conversation

yesmeck
Copy link
Contributor

@yesmeck yesmeck commented Apr 10, 2018

let is not supported on some old browsers.

@bvaughn
Copy link
Contributor

bvaughn commented Apr 10, 2018

Rats. Yes, this was unintentional. I will add a lint rule.

@bvaughn bvaughn merged commit 820d5dd into reactjs:master Apr 10, 2018
@bvaughn
Copy link
Contributor

bvaughn commented Apr 10, 2018 •
edited
Loading

Thanks! Published as 3.0.1

@yesmeck
Copy link
Contributor Author

yesmeck commented Apr 11, 2018

Template strings are also not supported on old browsers,

react-lifecycles-compat/index.js

Line 95 in 9190291

`${componentName} uses ${newApiName} but also contains the following legacy lifecycles:` +
do you consider add babel ?

@yesmeck yesmeck deleted the use-var branch April 11, 2018 03:43
@yesmeck yesmeck mentioned this pull request Apr 11, 2018
Closed
@dependencies dependencies bot mentioned this pull request Apr 16, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bvaughn bvaughn bvaughn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yesmeck @bvaughn