Update to match 16.4 gDSFP semantics #27
Open
+1,365
−61
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conceptually,
getDerivedStateFromProps
is like asetState
updater function. But it needs to be called after all the other updates in the queue, and it must be called exactly once, right beforeshouldComponentUpdate
.Other than
getDerivedStateFromProps
itself, there's no lifecycle that meets these requirements.componentWillReceiveProps
fires only if the props have changed.componentWillUpdate
fires too late.This polyfill works by monkeypatching
instance.updater
. updater is an internal-ish API that has stayed mostly stable across several major versions of React. The polyfill intercepts updates before they are added to the native update queue. Then it schedules a single update with the native update queue, in the form of an updater function. Inside that updater function, the intercepted updates are processed. Finally,getDerivedStateFromProps
is called and applied. This approach guarantees thatgetDerivedStateFromProps
is always called at the end.Note: The polyfill does not attempt to fix React 16.3. Components running in 16.3 will use the native, incorrect behavior. Consumers should upgrade to 16.4.
Unresolved questions:
instance.updater
in non-standard ways. As far as I can tell, there's no way to polyfillgetDerivedStateFromProps
correctly without relying on shallow renderer specific internals likeupdater._invokeCallbacks
andinstance._newState
.forceUpdate
. BecauseforceUpdate
does not accept asetState
updater function,getDerivedStateFromProps
will not be called as a result offorceUpdate
, unless it's part of the same batch as asetState
or an update on a parent component.