Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug in documentation: http://reactcommunity.org/react-modal/styles/classes/ has a link to a '404' page #833

Closed
hamirmahal opened this issue Oct 21, 2020 · 0 comments · Fixed by #834 · 4 remaining pull requests
Closed

bug in documentation: http://reactcommunity.org/react-modal/styles/classes/ has a link to a '404' page #833

hamirmahal opened this issue Oct 21, 2020 · 0 comments · Fixed by #834 · 4 remaining pull requests

Comments

@hamirmahal
Copy link
Contributor

Summary:

There's a link to default content styles in the Classes page of the documentation, but it appears to be invalid. For faster reference, here's what clicking on the link in the documentation looks like for me.

Screen Shot 2020-10-21 at 4 34 51 PM

Steps to reproduce:

  1. Visit http://reactcommunity.org/react-modal/styles/classes/.
  2. Scroll down until you reach the default content styles link. There is a screenshot below for quick reference.
  3. Click on it.

Screen Shot 2020-10-21 at 4 29 47 PM

Expected behavior:

I expected to see a page showing me the default content styles. Maybe this link should go to index.md instead?

Link to example of issue:

Link to nonexistent page linked from Classes page of documentation

Additional notes:

I looked at the history of the styles folder, and it looks like README.md existed on Dec 10, 2018 with commit 2ae092a, but not on Dec 9, 2019 with commit e5fe406.

So, my guess is that this is something that went amiss with the migration to mkdocs.

diasbruno pushed a commit that referenced this issue Nov 2, 2020
All this does is change the "default content styles" hyperlink to show `index.md` instead of `README.md`, since I think the link to `README.md` is stale since at least [Dec 9, 2019](https://github.com/reactjs/react-modal/tree/e5fe406111f97269b8a552e9fc5ee285e05941fa/docs/styles) with commit e5fe406.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant