-
Notifications
You must be signed in to change notification settings - Fork 809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added suport for isomorphic rendering #70
Conversation
Yes, that is needed! Now it fails when rendering isomorphic app. I suggest changing first line into: var _element = typeof document !== 'undefined' ? document.body : null; There is no point setting _element to string. |
Thanks @tkirda , I updated my pull request 👍 |
Would love to see this merged in 😄 |
Please merge this, it works perfectly. |
Totally agree, this PR works great ! |
rackt guys @gaearon @mzabriskie please merge this line and bump npm version pleeeeeaseee ⌚ |
Has anyone tested this diff with a screen reader? The fix would work for server rendering. Just need to make sure that once we're on the client |
It does not affect the behavior in any way, it's just to prevent exception when including file in nodejs runtime. Since |
Sounds good. Thanks! |
added suport for isomorphic rendering
Sweet! Looking forward to see it on NPM. |
Any idea on when a new release will be? |
I will update react to 0.14, and release today. |
Has this been published yet? I am still having this issue in version 0.5. |
Still doesn't work with meteor. |
It looks like the fix is included in 0.6.0. |
@ericntd In my |
I just added check if the component is running in browser or node.
Before when rendering on server there was an error