Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback to Render if Hydrate is not defined #839

Merged
merged 1 commit into from
Nov 13, 2017
Merged

Fallback to Render if Hydrate is not defined #839

merged 1 commit into from
Nov 13, 2017

Conversation

BookOfGreg
Copy link
Member

Fixes #832

Summary

ReactDOM.hydrate() may not be defined for everyone, it will now use
hydrate if it is defined or fallback to render.

Other Information

Will release a new package version followed by a gem version.

ReactDOM.hydrate() may not be defined for everyone, it will now use
hydrate if it is defined or fallback to render.

Fixes #832
@BookOfGreg
Copy link
Member Author

On an aside, I'll ask at work about getting some JS unit tests in place for situations like this integration and the jQuery bug.

@rmosolgo
Copy link
Member

🎉 !

@BookOfGreg BookOfGreg merged commit cac3e15 into reactjs:master Nov 13, 2017
@BookOfGreg BookOfGreg deleted the fix-#832 branch November 13, 2017 21:32
@BookOfGreg
Copy link
Member Author

Verified this version of UJS works with React 15.

screen shot 2017-11-13 at 23 39 51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants