-
-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allows arbitrary components anywhere inside <TabList> #139
Conversation
Thanks for your contribution. What happened when you where trying to add a dom node infront of the tabs? did it crash? |
The index was offset by 1 for each node, so with one preceding node the tab left to the one clicked would be selected. Also, navigating with the keyboard broke as the number of tabs ( I am getting an invariant error, though:
|
The invariant error seems to occur when I symlink my local fork of Weird! Don't really know what's happening. |
Would be great if someone would try this out! |
Let me know if you need an extra hand reviewing issues and PRs, @danez! |
Was this ever pulled into master? Any updates on it? |
Merged with 0a15604 |
Sweet, @danez! Just out of curiosity, why not merge normally? |
I merged a lot of other changes before (especially the rewrite to native classes) and so everything was a conflict and I had to pick by hand. |
Ah, I see. No need to apologise, I was just interested in the circumstances. :) |
This is a follow-up feature to #123, which allowed adding arbitrary components after a
<TabList>
's<Tab>
s.Now you can put components anywhere inside
<TabList>
and everything should work as expected.My use case was that I needed a logo-ish before the tabs. Tab group separators is another example.