Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isAppearing boolean is undefined when onEnter or onEntering is triggered #143

Closed
alonbt opened this issue Aug 3, 2017 · 4 comments · Fixed by AndreiShybin/metamask-extension#8 or yowainwright/Advanced-React#45 · May be fixed by Matthelonianxl/energyweb-ui#10, Matthelonianxl/nifty-wallet#6 or baophucct/metamask-extension#4
Closed

isAppearing boolean is undefined when onEnter or onEntering is triggered #143

alonbt opened this issue Aug 3, 2017 · 4 comments · Fixed by AndreiShybin/metamask-extension#8 or yowainwright/Advanced-React#45 · May be fixed by Matthelonianxl/energyweb-ui#10, Matthelonianxl/nifty-wallet#6 or baophucct/metamask-extension#4

Comments

@alonbt
Copy link
Contributor

alonbt commented Aug 3, 2017

I reproduce the issue here: https://jsfiddle.net/alonbt/no8c6yyw/

I'm trying to get the isAppearing parameter. it is always 'undefined'. Is it a bug or I might be using it wrong ?

  onEnter(node, isAppearing) {
    console.log('fade onEnter! node is', node, 'but why dont i see the appearing state?', isAppearing);
  }
  
  onEntering(node, isAppearing) {
    console.log('fade onEntering! node is', node, 'but why dont i see the appearing state?', isAppearing);
  }
@jquense
Copy link
Collaborator

jquense commented Aug 3, 2017

its a bug, I'm not quite sure why this is happening, if you want to take a crack at it go for it.

@alonbt
Copy link
Contributor Author

alonbt commented Aug 3, 2017

I'll give it my best shot!

@alonbt
Copy link
Contributor Author

alonbt commented Aug 3, 2017

fixed it: #144

@Lazyuki Lazyuki mentioned this issue Dec 20, 2018
Merged
jquense pushed a commit that referenced this issue Dec 20, 2018
@Lazyuki @jquense
fix: pass appear to CSSTransition callbacks (#441)
df7adb4 
Based on #144, but with working tests. Fixes #143.
jquense pushed a commit that referenced this issue Dec 20, 2018
@semantic-release-bot
chore(release): 2.5.2 [skip ci]
8f68611 
## [2.5.2](v2.5.1...v2.5.2) (2018-12-20)

### Bug Fixes

* pass appear to CSSTransition callbacks ([#441](#441)) ([df7adb4](df7adb4)), closes [#143](#143)
@jquense
Copy link
Collaborator

jquense commented Dec 20, 2018

🎉 This issue has been resolved in version 2.5.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

This was referenced Sep 24, 2019
Open
Open
This was referenced Mar 26, 2020
Merged
Open
@snyk-bot snyk-bot mentioned this issue Apr 13, 2020
Merged
johnfrench3 pushed a commit to johnfrench3/transition-group-react that referenced this issue Nov 2, 2022
chore(release): 2.5.2 [skip ci]
c049238 
## [2.5.2](reactjs/react-transition-group@v2.5.1...v2.5.2) (2018-12-20)

### Bug Fixes

* pass appear to CSSTransition callbacks ([#441](reactjs/react-transition-group#441)) ([df7adb4](reactjs/react-transition-group@df7adb4)), closes [#143](reactjs/react-transition-group#143)
patrickm68 added a commit to patrickm68/react-transition-group-developer that referenced this issue Dec 1, 2022
@patrickm68
chore(release): 2.5.2 [skip ci]
8fe7ebb 
## [2.5.2](reactjs/react-transition-group@v2.5.1...v2.5.2) (2018-12-20)

### Bug Fixes

* pass appear to CSSTransition callbacks ([#441](reactjs/react-transition-group#441)) ([df7adb4](reactjs/react-transition-group@df7adb4)), closes [#143](reactjs/react-transition-group#143)
shaikdev2 pushed a commit to shaikdev2/transition-group-react that referenced this issue Jun 9, 2023
@paxaxel223
chore(release): 2.5.2 [skip ci]
8258df1 
## [2.5.2](reactjs/react-transition-group@v2.5.1...v2.5.2) (2018-12-20)

### Bug Fixes

* pass appear to CSSTransition callbacks ([#441](reactjs/react-transition-group#441)) ([df7adb4](reactjs/react-transition-group@df7adb4)), closes [#143](reactjs/react-transition-group#143)
GreenCat1996 added a commit to GreenCat1996/react-transition-group that referenced this issue Aug 1, 2023
@GreenCat1996
chore(release): 2.5.2 [skip ci]
d3ea027 
## [2.5.2](reactjs/react-transition-group@v2.5.1...v2.5.2) (2018-12-20)

### Bug Fixes

* pass appear to CSSTransition callbacks ([#441](reactjs/react-transition-group#441)) ([df7adb4](reactjs/react-transition-group@df7adb4)), closes [#143](reactjs/react-transition-group#143)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jquense @alonbt