Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add initial Rules of React docs #6680

Merged
merged 37 commits into from
Mar 15, 2024
Merged

Add initial Rules of React docs #6680

merged 37 commits into from
Mar 15, 2024

Conversation

poteto
Copy link
Member

@poteto poteto commented Mar 5, 2024

@vercel Vercel
Copy link

vercel bot commented Mar 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
react-dev ✅ Ready (Inspect) Visit Preview Mar 15, 2024 3:55pm

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024 •
edited
Loading

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/[[...markdownPath]] 81.52 KB (🟡 +87 B) 185.42 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@poteto poteto force-pushed the lt/rules-of-react branch from 06d10d0 to bf7d330 Compare March 6, 2024 21:38
eps1lon
eps1lon reviewed Mar 6, 2024
View reviewed changes
Copy link
Collaborator

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it. Finally something to link to 🥳

@poteto poteto force-pushed the lt/rules-of-react branch from d9e429d to 9a8fc09 Compare March 8, 2024 20:23
@poteto poteto force-pushed the lt/rules-of-react branch from 9a8fc09 to a4f0530 Compare March 11, 2024 15:30
@poteto poteto force-pushed the lt/rules-of-react branch from 5ed5040 to 8e50692 Compare March 12, 2024 16:15
@poteto poteto changed the title WIP for early feedback Add initial Rules of React docs Mar 12, 2024
@poteto poteto marked this pull request as ready for review March 12, 2024 16:19
@poteto poteto force-pushed the lt/rules-of-react branch from fb78e8d to 69ba7cd Compare March 14, 2024 16:02
@poteto poteto force-pushed the lt/rules-of-react branch from 05de9bd to afbaa52 Compare March 14, 2024 16:22
mattcarrollcode
mattcarrollcode reviewed Mar 14, 2024
View reviewed changes
src/sidebarReference.json Show resolved Hide resolved
src/content/reference/rules/index.md Outdated Show resolved Hide resolved
src/content/reference/rules/index.md Outdated Show resolved Hide resolved
@poteto poteto merged commit 0dc1b31 into main Mar 15, 2024
4 checks passed
@poteto poteto deleted the lt/rules-of-react branch March 15, 2024 16:00
@stephan-noel stephan-noel mentioned this pull request Mar 23, 2024
Closed
@stephan-noel stephan-noel mentioned this pull request Apr 27, 2024
Open
@AhmedBaset AhmedBaset mentioned this pull request Jun 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pwbriggs pwbriggs pwbriggs left review comments

@harish-sethuraman harish-sethuraman harish-sethuraman left review comments

@eps1lon eps1lon eps1lon left review comments

@jackpope jackpope jackpope left review comments

@mattcarrollcode mattcarrollcode mattcarrollcode left review comments

@josephsavona josephsavona josephsavona left review comments

@rickhanlonii rickhanlonii rickhanlonii left review comments

@kassens kassens kassens left review comments

Assignees
No one assigned
Labels
CLA Signed react core team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.