Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finished translation of "Scaling up with reducer and context" #561

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

astropsy999
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Aug 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
uk-legacy-reactjs-org ⬜️ Ignored (Inspect) Visit Preview Aug 18, 2024 5:33pm

Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Five Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 104.74 KB (🟡 +38 B) 208.94 KB
/500 104.74 KB (🟡 +38 B) 208.93 KB
/[[...markdownPath]] 106.71 KB (🟡 +38 B) 210.9 KB
/errors 104.95 KB (🟡 +38 B) 209.15 KB
/errors/[errorCode] 104.93 KB (🟡 +38 B) 209.12 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link
Collaborator

@alinkedd alinkedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

На цьому тижні передивлюсь цей PR

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ось цього файла тут не має бути

Copy link
Collaborator

@alinkedd alinkedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Перша частина перевірки: усі ці зауваження мають бути виправлені у всьому PR.

Друга частина перевірки буде після злиття #560 і виправлень першої частини перевірки - інакше у мене накладається складність коректури одного і того ж

@@ -1,24 +1,24 @@
---
title: Scaling Up with Reducer and Context
title: Масштабування з використанням контексту та ред'юсера
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/reactjs/uk.react.dev/pull/560/files#r1755258585

тут і далі - редюсер

Suggested change
title: Масштабування з використанням контексту та ред'юсера
title: Масштабування з використанням контексту та редюсера

---

<Intro>

Reducers let you consolidate a component's state update logic. Context lets you pass information deep down to other components. You can combine reducers and context together to manage state of a complex screen.
Ред'юсери дозволяють об'єднати логіку оновлення стану компонента. Контекст дозволяє передавати інформацію у глибину до інших компонентів. Ви можете поєднати ред'юсери і контекст, щоб управляти станом складного інтерфейсу.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

тут і далі - "дозволяти" у непрямому значення замінити на "давати змогу"

https://onlinecorrector.com.ua/uk/%D0%B4%D0%B0%D0%B2%D0%B0%D1%82%D0%B8-%D0%B7%D0%BC%D0%BE%D0%B3%D1%83-%D0%BD%D0%B0%D0%B3%D0%BE%D0%B4%D1%83/

@@ -57,7 +57,7 @@ export default function TaskApp() {

return (
<>
<h1>Day off in Kyoto</h1>
<h1>Вихідний у Кіото</h1>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

тут і далі - приклади мають співпадати. тут приклади мають співпадати з https://github.com/reactjs/uk.react.dev/pull/560/files

тобто треба або тут і далі

Suggested change
<h1>Вихідний у Кіото</h1>
<h1>Вихідний день у Кіото</h1>

або в прикладі в іншому PR забрати "день"

{ id: 0, text: 'Philosopher’s Path', done: true },
{ id: 1, text: 'Visit the temple', done: false },
{ id: 2, text: 'Drink matcha', done: false }
{ id: 0, text: 'Шлях філософів', done: true },
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

тут і далі

Suggested change
{ id: 0, text: 'Шлях філософів', done: true },
{ id: 0, text: 'Шлях філософа', done: true },

@@ -113,14 +113,14 @@ export default function AddTask({ onAddTask }) {
return (
<>
<input
placeholder="Add task"
placeholder="Додати задачу"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

тут і далі

Suggested change
placeholder="Додати задачу"
placeholder="Додати завдання"

Comment on lines +213 to 216

```jsx
<TaskList tasks={tasks} dispatch={dispatch} />

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

лишнє, треба дотримуватися line-by-line parity

Suggested change
```jsx
<TaskList tasks={tasks} dispatch={dispatch} />

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants