Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate API Reference - React #20

Merged
merged 5 commits into from
Mar 16, 2019
Merged

Translate API Reference - React #20

merged 5 commits into from
Mar 16, 2019

Conversation

Quynh-Nguyen
Copy link
Contributor

Complete translation for API Reference - React page.

Please help me take a look and give me any feedback.

@netlify
Copy link

netlify bot commented Mar 6, 2019

Deploy preview for vi-reactjs-org ready!

Built with commit bb49046

https://deploy-preview-20--vi-reactjs-org.netlify.com

@netlify
Copy link

netlify bot commented Mar 6, 2019 •
edited
Loading

Deploy preview for vi-reactjs-org ready!

Built with commit 04e73b3

https://deploy-preview-20--vi-reactjs-org.netlify.com

@nampdn nampdn requested review from ltmylinh and nampdn March 7, 2019 17:03
@Quynh-Nguyen
Copy link
Contributor Author

@NhanHoang8195
I see you're translating same API Reference with me.
So could you please help me review my translate part bro?

@NhanHoang8195
Copy link
Contributor

So could you please help me review my translate part bro?
@Quynh-Nguyen
Sorry, I think i haven't enough good both exp and skills to review technical translation.

@ltmylinh
Copy link
Collaborator

ltmylinh commented Mar 9, 2019

@NhanHoang8195 : Em có time thì review các PR luôn, ở đây mình ko có phân biệt kinh nghiệm hay gì đâu em. Mỗi người góp ý cho nhau thì việc translate sẽ tốt hơn. Chị ko hiểu sao chị ko thể request em ở list reviewers được. Nhưng em có thể "feel free to review any PRs" nếu em có time nhé.

@tesseralis tesseralis mentioned this pull request Mar 9, 2019
Closed
95 tasks
ltmylinh
ltmylinh reviewed Mar 15, 2019
View reviewed changes
content/docs/reference-react.md Outdated Show resolved Hide resolved
content/docs/reference-react.md Outdated Show resolved Hide resolved
content/docs/reference-react.md Outdated Show resolved Hide resolved
content/docs/reference-react.md Outdated Show resolved Hide resolved
content/docs/reference-react.md Outdated Show resolved Hide resolved
content/docs/reference-react.md Outdated Show resolved Hide resolved
content/docs/reference-react.md Outdated Show resolved Hide resolved
content/docs/reference-react.md Outdated Show resolved Hide resolved
content/docs/reference-react.md Outdated Show resolved Hide resolved
content/docs/reference-react.md Outdated Show resolved Hide resolved
@Quynh-Nguyen
Copy link
Contributor Author

@ltmylinh Cảm ơn góp ý của chị.
Em đã cập nhật lại Pull request.

@ltmylinh
Copy link
Collaborator

Thanks em.

@ltmylinh ltmylinh merged commit d7a88a0 into reactjs:master Mar 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ltmylinh ltmylinh ltmylinh approved these changes

@nampdn nampdn Awaiting requested review from nampdn

Assignees
No one assigned
Labels
In Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Quynh-Nguyen @NhanHoang8195 @ltmylinh @nampdn