Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added uncaught exceptions to method signature #112

Closed
wants to merge 1 commit into from
Closed

added uncaught exceptions to method signature #112

wants to merge 1 commit into from

Conversation

62mkv
Copy link
Contributor

@62mkv 62mkv commented Apr 24, 2020

as per IntelliJ suggestions

pderop
pderop approved these changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@pderop pderop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@62mkv ,

Thanks for this, I'm going to merge this (a bit overdue 😉) PR !

@pderop pderop self-assigned this Jan 13, 2023
@pderop pderop added the type/documentation A documentation update label Jan 13, 2023
@pderop pderop added this to the 1.0.7.RELEASE milestone Jan 13, 2023
pderop added a commit to pderop/BlockHound that referenced this pull request Jan 23, 2023
@pderop
Applied patch from old PR reactor#112 which can't be merged
79b2a29
@pderop pderop mentioned this pull request Jan 23, 2023
Merged
pderop added a commit that referenced this pull request Jan 23, 2023
@pderop
Applied patch from old PR #112 which can't be merged (#326)
77ac45a 
Added uncaught exceptions to test method signature.

This PR manually applies the old PR #112 (thanks to @62mkv), which was created a long time ago by but which can't be currently merged.
@pderop pderop added type/enhancement A general enhancement and removed type/enhancement A general enhancement labels Jan 23, 2023
@pderop pderop removed this from the 1.0.7.RELEASE milestone Jan 23, 2023
@pderop
Copy link
Contributor

pderop commented Jan 23, 2023 •
edited
Loading

@62mkv , thanks for this (old) PR.

But it seems I can't merge it, so I have created a new one (#326) where I have manually applied your original fix.
Superseded by #326

@pderop pderop closed this Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pderop pderop pderop approved these changes

Assignees

@pderop pderop

Labels
type/documentation A documentation update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@62mkv @pderop