Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dynamic predicate to be evaluated on thread that installs Block… #123

Closed
wants to merge 1 commit into from
Closed

Allow dynamic predicate to be evaluated on thread that installs Block… #123

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions agent/src/main/java/reactor/blockhound/BlockHound.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,6 +403,8 @@ public void install() {
// Eagerly trigger the classloading of `dynamicThreadPredicate` (since classloading is blocking)
dynamicThreadPredicate.test(Thread.currentThread());
BlockHoundRuntime.dynamicThreadPredicate = dynamicThreadPredicate;
// Null out the state so it can be evaluated with the configured dynamicThreadPredicate
BlockHoundRuntime.STATE.set(null);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI it should be ThreadLocal#remove as seen here:
https://github.com/reactor/BlockHound/pull/124/files#diff-21558a210d558456b0f5da4268364dc3R414


// Eagerly trigger the classloading of `threadPredicate` (since classloading is blocking)
threadPredicate.test(Thread.currentThread());
Expand Down