Introduce boolean functions to simplify combining Mono<Boolean> inputs #161
Conversation
gregturn
commented
Aug 13, 2018
gregturn
commented
- not(value)
- and(value1, value2)
- or(value1, value2)
- nand(value1, value2)
- nor(value1, value2)
- xor(value1, value2)
| * @param value2 second boolean | ||
| * @return {@literal value1 && value2} wrapped in a {@link Mono} | ||
| */ | ||
| public static Mono<Boolean> and(Mono<Boolean> value1, Mono<Boolean> value2) { |
There was a problem hiding this comment.
could use Mono.zip(value1, value2, (a, b) -> a && b)
| * | ||
| * @author Greg Turnquist | ||
| */ | ||
| public final class BoolUtils { |
There was a problem hiding this comment.
maybe rename to BooleanUtils for consistency with Mono<Boolean>?
There was a problem hiding this comment.
Actually I was going for that, but discovered that reactor.boolean wasn't a valid package name due to boolean being a reserved word.
Either way, I can go for.
There was a problem hiding this comment.
bool in the package is fine by me, the class name feels weird though, so I would just change that
| */ | ||
| public static Mono<Boolean> or(Mono<Boolean> value1, Mono<Boolean> value2) { | ||
| return value1 | ||
| .flatMap(bool1 -> value2 |
| */ | ||
| public static Mono<Boolean> xor(Mono<Boolean> value1, Mono<Boolean> value2) { | ||
| return value1 | ||
| .flatMap(bool1 -> value2 |
| @Test | ||
| public void testNot() { | ||
| StepVerifier.create(not(TRUE)) | ||
| .assertNext(bool -> assertThat(bool).isFalse()); |
There was a problem hiding this comment.
nitpicking or tip? in all these tests I'd tend to use assertThat(...).as("xxx"), otherwise any failure would look like "org.junit.ComparisonFailure: Expected :false Actual :true".
eg.
StepVerifier.create(not(TRUE))
.assertNext(bool -> assertThat(bool).as("not(TRUE)").isFalse())
.verifyComplete();
would now look like:
org.junit.ComparisonFailure: [not(TRUE)]
Expected :false
Actual :true
| public void testNot() { | ||
| StepVerifier.create(not(TRUE)) | ||
| .assertNext(bool -> assertThat(bool).isFalse()); | ||
|
|
There was a problem hiding this comment.
missing a .verifyComplete();
| .assertNext(bool -> assertThat(bool).isFalse()); | ||
|
|
||
| StepVerifier.create(not(FALSE)) | ||
| .assertNext(bool -> assertThat(bool).isTrue()); |
|
ah @gregturn another issue: the test uses TestNG annotations not JUnit ;) |
* not(value) * and(value1, value2) * or(value1, value2) * nand(value1, value2) * nor(value1, value2) * xor(value1, value2)
|
IntelliJ!!!! Fixed. |
