Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #164 Avoid ArithmeticException on exponential backoff #166

Merged
merged 1 commit into from
Aug 30, 2018
Merged

fix #164 Avoid ArithmeticException on exponential backoff #166

merged 1 commit into from
Aug 30, 2018

Conversation

simonbasle
Copy link
Member

This commit avoids backoff duration growing too large by:

  1. not doing any computation if the current backoff is already equal to
    configured maxBackoff
  2. catching an ArithmeticException and setting the next backoff to
    maxBackoff in that case

@simonbasle
fix #164 Avoid ArithmeticException on exponential backoff
02675c3 
This commit avoids backoff duration growing too large by:
 1) not doing any computation if the current backoff is already equal to
 configured maxBackoff
 2) catching an `ArithmeticException` and setting the next backoff to
 maxBackoff in that case
@simonbasle simonbasle added this to the 3.1.7.RELEASE milestone Aug 28, 2018
@simonbasle simonbasle mentioned this pull request Aug 29, 2018
Closed
@simonbasle simonbasle merged commit 93bd2ca into 3.1.x Aug 30, 2018
@simonbasle simonbasle deleted the 164-backoffArithmetic branch August 30, 2018 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smaldini smaldini smaldini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1.7.RELEASE
Development

Successfully merging this pull request may close these issues.
2 participants
@simonbasle @smaldini