Refactor and add tests for optimized assembly traceback #3949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chemicL
added
area/performance
|
Oh nice! Sorry for not yet replying in the other PR; I'm currently packing boxes as I'll move apartments on Friday, and the deadline is looming 😅. I might find some time for a closer look EOD, but please don't feel the need to wait for me. 👍 |
|
Only just now noticed that #3901 was merged. Thanks! 🚀 |
chemicL
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Stephan202 this is a follow-up to #3901 with the most recent feedback and the String-view utility tests and fixes.