Wrong host port when only X-Forwarded-Proto
is present
#2773
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
When resolving forwarded headers (X-Forwarded/Forwarded), the following scenario seems to happen in cloud foundry:
Host
header without any port, as well as aX-Forwarded-Proto: https
headerDefaultHttpForwardedHeaderHandler
class will wrongly resolve the host port as80
instead of 443, because the request is received on a non-secure connection.Have also applied the similar patch for Forwarded headers (like
Forwarded: proto=https
).Fixes #2771