-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always add proxy.address
tag for the client metrics
#3230
Conversation
When there is no proxy add `na` as a value tag. Fixes #3218
in MicrometerChannelMetricsRecorder.java, line 176, is the following method still used ? if not, can we remove it ?
|
It is not used, unfortunately the class/method is public and we cannot remove it. May be just deprecate it as unused? |
yes, indeed, it can't be removed, in this case, we can deprecate it. |
please check the new commit |
@pderop Thanks for the review! |
When there is no proxy add
na
as a value tag.Fixes #3218