Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ClassCastException in HttpOperations#initShortId() #3542

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Fix ClassCastException in HttpOperations#initShortId() #3542

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48df8a9
Fix ClassCastException in `HttpOperations#initShortId()`
joschi Dec 11, 2024
5f90ca9
Use channel from original Connection instance
joschi Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions reactor-netty-http/src/main/java/reactor/netty/http/HttpOperations.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,8 +377,9 @@ protected final boolean markSentHeaderAndBody(Object... objectsToRelease) {

@Override
protected final String initShortId() {
if (connection() instanceof AtomicLong) {
return channel().id().asShortText() + '-' + ((AtomicLong) connection()).incrementAndGet();
Connection connection = connection();
if (connection instanceof AtomicLong) {
return channel().id().asShortText() + '-' + ((AtomicLong) connection).incrementAndGet();
joschi marked this conversation as resolved.
Show resolved Hide resolved
}
return super.initShortId();
}
Expand Down