Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release: move tagging step at the end #699

Closed
8 tasks done
simonbasle opened this issue May 11, 2021 · 0 comments
Closed
8 tasks done

Release: move tagging step at the end #699

simonbasle opened this issue May 11, 2021 · 0 comments
Assignees
Labels
area/all-projects issues that are transverse to all projects, epics

Comments

@simonbasle
Copy link
Contributor

simonbasle commented May 11, 2021

The tagging step should be performed once the bits have been propagated to Sonatype and/or Artifactory, rather than once the tests pass.

It is not super important, but still better in case something goes wrong in the deployment to these external repositories (wrong credentials configured in env, service down or what have you), since it then means the tag has to be recreated.

Tracking state per project:

  • reactor-core
  • reactor-addons
  • reactor-pool
  • reactor-netty
  • reactor-kafka
  • reactor-rabbitmq
  • reactor-kotlin-extensions
  • reactor
@simonbasle simonbasle added the area/all-projects issues that are transverse to all projects, epics label May 11, 2021
@simonbasle simonbasle self-assigned this May 11, 2021
simonbasle added a commit to reactor/reactor-core that referenced this issue May 11, 2021
simonbasle added a commit to reactor/reactor-addons that referenced this issue May 11, 2021
Now part of publish (milestone/release) jobs, instead of prepare.
The `fullVersion` is added to output of prepare.

See reactor/reactor#699.
simonbasle added a commit to reactor/reactor-pool that referenced this issue May 11, 2021
Now part of publish (milestone/release) jobs, instead of prepare.
The `fullVersion` is added to output of prepare.

See reactor/reactor#699.
simonbasle added a commit to reactor/reactor-netty that referenced this issue May 11, 2021
Now part of publish (milestone/release) jobs, instead of prepare.
The `fullVersion` is added to output of prepare.

See reactor/reactor#699.
simonbasle added a commit to reactor/reactor-kafka that referenced this issue May 11, 2021
Was already part of publish (milestone/release) jobs, but it needed the
`fullVersion` added to output of prepare.

See reactor/reactor#699.
simonbasle added a commit to reactor/reactor-rabbitmq that referenced this issue May 11, 2021
Was already part of publish (milestone/release) jobs, but it needed the
`fullVersion` added to output of prepare.

See reactor/reactor#699.
simonbasle added a commit to reactor/reactor-kotlin-extensions that referenced this issue May 11, 2021
Was already part of publish (milestone/release) jobs, but it needed the
`fullVersion` added to output of prepare.

See reactor/reactor#699.
simonbasle added a commit that referenced this issue May 11, 2021
Now part of publish (milestone/release) jobs, instead of prepare.
The `fullVersion` is added to output of prepare.

See #699.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/all-projects issues that are transverse to all projects, epics
Projects
None yet
Development

No branches or pull requests

1 participant