Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test suite to use default loop #438

Merged
merged 2 commits into from
Jan 23, 2022
Merged

Update test suite to use default loop #438

merged 2 commits into from
Jan 23, 2022

Conversation

clue
Copy link
Member

@clue clue commented Jan 23, 2022

Builds on top of #410, #417, #418, #419, clue/reactphp-block#60, reactphp/socket#283 and others

@clue clue added this to the v1.6.0 milestone Jan 23, 2022
@clue clue requested a review from WyriHaximus January 23, 2022 18:59
WyriHaximus
WyriHaximus approved these changes Jan 23, 2022
View reviewed changes
Copy link
Member

@WyriHaximus WyriHaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't wait to use react/async for the awaits

@WyriHaximus WyriHaximus merged commit 6acf1a7 into reactphp:master Jan 23, 2022
@clue clue deleted the tests branch January 23, 2022 20:23
@clue clue mentioned this pull request Aug 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WyriHaximus WyriHaximus WyriHaximus approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@clue @WyriHaximus