Add functional integration tests #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's a dependency graph that shows this cyclic dependency (generated via https://github.com/clue/graph-composer): The Note that this only applies when this is the root package, i.e. it does happen in a local test setup but will not happen when you use this project as a library and add any of these packages as a normal dependency. One possible way to avoid this is to explicitly define the root package version as per https://getcomposer.org/doc/03-cli.md#composer-root-version: $ COMPOSER_ROOT_VERSION=`git describe --abbrev=0` composer update |
clue
changed the title
|
PR updated and ready for review |
jsor
reviewed
Dec 29, 2016
| @@ -144,6 +145,23 @@ $ composer require react/socket:^0.4.4 | |||
|
|
|||
| More details about version upgrades can be found in the [CHANGELOG](CHANGELOG.md). | |||
|
|
|||
| ## Tests | |||
|
|
|||
| The run the test suite, you first need to clone this repo and then install all | |||
WyriHaximus
approved these changes
Dec 29, 2016
We currently have an indirect cyclic dependency between socket -> socket-client -> dns -> socket which causes the test setup to fail otherwise.
clue
force-pushed
the
integration-tests
branch
from
99e37e9 to
8740211
Compare
|
Thanks for spotting! Amended the last commit |
WyriHaximus
approved these changes
Dec 29, 2016
jsor
approved these changes
Dec 30, 2016
clue
pushed a commit
to clue-labs/socket
that referenced
this pull request
Mar 29, 2017
First class support for PHP7 and HHVM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simple PR aims to add a functional integration test (which also happens to be a prerequisite for implementing #24).
Unfortunately, this simple change introduces an indirect cyclic dependency between
socket -> socket-client -> dns -> socketwhich causes the test setup to fail. I'm opening this PR in the hope to propose and discuss a possible solution.