Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hooks in Action Complete #131

Merged
merged 25 commits into from
May 17, 2022
Merged

Hooks in Action Complete #131

merged 25 commits into from
May 17, 2022

Conversation

Abhishek-90
Copy link
Contributor

@Abhishek-90 Abhishek-90 commented May 3, 2022

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #107

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@vercel
Copy link

vercel bot commented May 3, 2022

Someone is attempting to deploy a commit to a Personal Account owned by @atapas on Vercel.

@atapas first needs to authorize it.

@Abhishek-90
Copy link
Contributor Author

#107

@vercel
Copy link

vercel bot commented May 3, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-play ✅ Ready (Inspect) Visit Preview May 17, 2022 at 8:08AM (UTC)

src/meta/play-meta.js Outdated Show resolved Hide resolved
@atapas
Copy link
Member

atapas commented May 3, 2022

@Abhishek-90 kindly test the play in responsive modes.

@Abhishek-90
Copy link
Contributor Author

@atapas tested and updated!

src/plays/quote-generator/quoteGenerator.css Outdated Show resolved Hide resolved
src/meta/play-meta.js Outdated Show resolved Hide resolved
@atapas
Copy link
Member

atapas commented May 4, 2022

@atapas tested and updated!

@Abhishek-90 A couple of comments are opened.

@atapas
Copy link
Member

atapas commented May 4, 2022

@atapas tested and updated!

Responsive changes are looking good.

@Abhishek-90
Copy link
Contributor Author

@atapas the change in play-meta file is due to a shift of opening brace a line above

@atapas
Copy link
Member

atapas commented May 10, 2022

@Abhishek-90 Is this ready to review?

@Abhishek-90
Copy link
Contributor Author

@atapas yes, it's ready

Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Abhishek-90 Here are a few change requests.

src/meta/play-meta.js Outdated Show resolved Hide resolved
src/plays/quote-generator/QuoteGenerator.jsx Outdated Show resolved Hide resolved
src/plays/quote-generator/quoteGenerator.css Outdated Show resolved Hide resolved
@atapas
Copy link
Member

atapas commented May 16, 2022

@Abhishek-90 I have given a few review comments and please create an issue and associate it with the PR.

Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@atapas atapas merged commit 8c72a4f into reactplay:main May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hooks in Actions
2 participants