-
-
Notifications
You must be signed in to change notification settings - Fork 838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hooks in Action Complete #131
Conversation
Hooks play
Hooks play
Someone is attempting to deploy a commit to a Personal Account owned by @atapas on Vercel. @atapas first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@Abhishek-90 kindly test the play in responsive modes. |
@atapas tested and updated! |
@Abhishek-90 A couple of comments are opened. |
Responsive changes are looking good. |
@atapas the change in play-meta file is due to a shift of opening brace a line above |
@Abhishek-90 Is this ready to review? |
@atapas yes, it's ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Abhishek-90 Here are a few change requests.
@Abhishek-90 I have given a few review comments and please create an issue and associate it with the PR. |
Quote Generator changed to Random Quote Generator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #107
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Checklist: