Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: footer position #1450 #1453

Closed
wants to merge 3 commits into from
Closed

Conversation

prasenarthi
Copy link

@prasenarthi prasenarthi commented Feb 14, 2024

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #1450

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots or example output

Copy link

netlify bot commented Feb 14, 2024

Deploy Preview for reactplayio ready!

Name Link
🔨 Latest commit e45875c
🔍 Latest deploy log https://app.netlify.com/sites/reactplayio/deploys/65d9ff9765ddd40008d5b72f
😎 Deploy Preview https://deploy-preview-1453--reactplayio.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! contributor, thank you for opening a Pull Request 🎉.

@reactplay/maintainers will review your submission soon and give you helpful feedback. If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.

@prasenarthi
Copy link
Author

hey @priyankarpal . i have raised a PR with the following bug fix. please check

@priyankarpal priyankarpal changed the title #1450- BUG FIX : footer position fix: footer position #1450 Feb 14, 2024
@priyankarpal
Copy link
Member

@prasenarthi in future please create separate branch for pull request

@priyankarpal priyankarpal added waiting for reviewers 🛠 goal: fix Bug fix 🚧 status: blocked Blocked & therefore, not ready for work and removed 🛠 goal: fix Bug fix labels Feb 14, 2024
Copy link

netlify bot commented Feb 17, 2024

Priyankar left a comment:

I believe the footer is not placed correctly

recording

Browser metadata
Path:      /
Browser:   Chrome 121.0.0.0 on Linux x86_64
Viewport:  1920 x 932 @1x
Language:  en-GB
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Resolved

@priyankarpal priyankarpal added changes required need to change some thing and removed 🚧 status: blocked Blocked & therefore, not ready for work labels Feb 17, 2024
@priyankarpal
Copy link
Member

any updates? @prasenarthi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Bug report]: need to fix footer position
2 participants